From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: Build problems with xen 4.7
Date: Tue, 1 Dec 2015 19:53:14 +0000
Message-ID: <565DFAAA.2000903@citrix.com>
References: <alpine.DEB.2.00.1511302332250.32657@procyon.dur.ac.uk>
	<565DAC7402000078000BACE9@prv-mh.provo.novell.com>
	<5BB49958-6315-4EAA-967C-73FC9B442B73@oracle.com>
	<565DD12302000078000BAE6B@prv-mh.provo.novell.com>
	<20151201155941.GG19885@char.us.oracle.com>
	<565DD43602000078000BAEA1@prv-mh.provo.novell.com>
	<alpine.DEB.2.00.1512011842490.8877@procyon.dur.ac.uk>
	<20151201194010.GA15998@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20151201194010.GA15998@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>, M A Young <m.a.young@durham.ac.uk>
Cc: Marcos Matsunaga <marcos.matsunaga@oracle.com>, Jan Beulich <JBeulich@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 01/12/15 19:40, Olaf Hering wrote:
> On Tue, Dec 01, M A Young wrote:
>
>> It happens if CFLAGS is set to anything as a environment variable, eg.
>> export CFLAGS=" "
>> make dist-xen
> This never worked.

Works for me with CentOS-based RPM builds. 
(https://github.com/xenserver/xen-4.6.pg/blob/master/master/builder-makefiles.patch#L413
from XenServer)

>  I have this in xen.spec to workaround the way
> %configure is implemented in rpm:
>
> %configure <whatever>
> unset CFLAGS
> unset CXXFLAGS
> unset FFLAGS
> unset LDFLAGS
> make <whatever>

Requiring these unset's is definitely buggy behaviour, and should be fixing.

For me, the example given by Michael breaks even earlier.

andrewcoop@andrewcoop:/local/xen.git/xen$ CFLAGS=" " make -j4 -s
 __  __            _  _    __    _                  
 \ \/ /___ _ __   | || |  / /_  / |   _ __  _ __ ___
  \  // _ \ '_ \  | || |_| '_ \ | |__| '_ \| '__/ _ \
  /  \  __/ | | | |__   _| (_) || |__| |_) | | |  __/
 /_/\_\___|_| |_|    |_|(_)___(_)_|  | .__/|_|  \___|
                                     |_|            
Fields of 'compat_gnttab_cache_flush' not found in 'compat/grant_table.h'
Makefile:70: recipe for target 'compat/.xlat/grant_table.h' failed
make[2]: *** [compat/.xlat/grant_table.h] Error 1
make[2]: *** Waiting for unfinished jobs....
Fields of 'compat_mem_access_op' not found in 'compat/memory.h'
Makefile:70: recipe for target 'compat/.xlat/memory.h' failed
make[2]: *** [compat/.xlat/memory.h] Error 1
Makefile:104: recipe for target '/local/xen.git/xen/xen' failed
make[1]: *** [/local/xen.git/xen/xen] Error 2
Makefile:29: recipe for target 'build' failed
make: *** [build] Error 2


~Andrew