From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH RFC XEN v1 10/14] tools: Switch a few CONFIG_MIGRATE features to CONFIG_X86 Date: Wed, 9 Dec 2015 15:16:34 +0000 Message-ID: <566845D2.5000809@citrix.com> References: <1449671507.16124.264.camel@citrix.com> <1449671548-4050-10-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1449671548-4050-10-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org, stefano.stabellini@eu.citrix.com, julien.grall@citrix.com List-Id: xen-devel@lists.xenproject.org On 09/12/15 14:32, Ian Campbell wrote: > offline_page and compression are under a CONFIG_MIGRATE (out of > context) and along with xen-hptool these seem to rely on features > currently implemented only on x86. > > I am shortly going to be enabling CONFIG_MIGRATE for ARM, but these > features are not yet available there. > > I'm not sure if these are intrinsically x86 or if they deserve their > own options. > > Signed-off-by: Ian Campbell > Cc: andyhhp > --- > xc_compression.c seems to actually be unused, possibly since migration > v2, perhaps pending colo? Yes - migration v2 didn't add the page compression support. I should have included this in the "Areas for improvement" in the feature document. xc_offline_page has nothing to do with migration, although it used to share some infrastructure, which I suspect is why the two are linked. xen-hptool (which I keep on mistaking for a brand of hardware vendor) is a command line utility which uses some of xc_offline_page.c ~Andrew