From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH RFC XEN v1 13/14] tools: libxc: wire up migration for ARM Date: Wed, 9 Dec 2015 15:48:21 +0000 Message-ID: <56684D45.1040306@citrix.com> References: <1449671507.16124.264.camel@citrix.com> <1449671548-4050-13-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1449671548-4050-13-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org, stefano.stabellini@eu.citrix.com, julien.grall@citrix.com List-Id: xen-devel@lists.xenproject.org On 09/12/15 14:32, Ian Campbell wrote: > This seems almost too easy. I am glad that a healthy quantity of time has passed since the 4.6 dev window. Easy is not how I would have described this back then! > diff --git a/tools/libxc/xc_sr_common_arm.h b/tools/libxc/xc_sr_common_arm.h > new file mode 100644 > index 0000000..efbea70 > --- /dev/null > +++ b/tools/libxc/xc_sr_common_arm.h > @@ -0,0 +1,15 @@ > +#ifndef __COMMON_ARM__H > +#define __COMMON_ARM__H > + > +#include "xc_sr_common.h" > + > +#endif > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * tab-width: 4 > + * indent-tabs-mode: nil > + * End: > + */ Given how small this is, I would just drop it and include xc_sr_common.h directly. It only exists on the x86 side because of the magic TSC handling which is common between PV and HVM guests. ~Andrew