Re: [PATCH 8/9] xenstore: write xenstore domain data to xenstore

[Juergen Gross <jgross@suse.com>]

On 15/12/15 13:49, Ian Campbell wrote:
> On Tue, 2015-12-15 at 13:34 +0100, Juergen Gross wrote:
>> On 15/12/15 13:26, Ian Campbell wrote:
>>> On Fri, 2015-12-11 at 16:47 +0100, Juergen Gross wrote:
>>>> After starting the xenstore domain write the basic data (domid and
>>>> name) to the xenstore.
>>>>
>>>> Add a new option to init-xenstore-domain to be able to specify the
>>>> domain's name.
>>>
>>> Is all this enough to keep "xl list" etc happy?
>>
>> I hope so. At least I didn't notice any problems.
> 
> Great. Please could you add "This makes the domain appear correctly in xl
> list" or something similar.

Sure.

>>> Do we need to also create a dummy json object like we do for dom0
>>> (init-
>>> xen-dom0)?
>>
>> Good question. Depends on what the dom0 json object is used for.
> 
> Mostly for various types of hotplug (irrelevant here I guess?) and reboot
> (also irrelevant?).

I think so (the "irrelevant" part).

> Maybe also "xl list -v" or some other "look more closely" xl commands?

Hmm, I'll have a closer look.

> mem-set too perhaps?

Without mini-os supporting ballooning or memory hotplug up to now:
I don't think so. :-)


Juergen