From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH RFC XEN v1 03/14] xen: arm: switch
 arch_do_domctl to a common exit path
Date: Tue, 15 Dec 2015 17:07:22 +0000
Message-ID: <567048CA.1020106@citrix.com>
References: <1449671507.16124.264.camel@citrix.com>
	<1449671548-4050-3-git-send-email-ian.campbell@citrix.com>
	<alpine.DEB.2.02.1512151623270.17516@kaball.uk.xensource.com>
	<1450198655.16856.210.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1450198655.16856.210.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: julien.grall@citrix.com, wei.liu2@citrix.com, ian.jackson@eu.citrix.com, Jan Beulich <JBeulich@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 15/12/15 16:57, Ian Campbell wrote:
> On Tue, 2015-12-15 at 16:34 +0000, Stefano Stabellini wrote:
>>  .. .arch_do_domclt...
>>> +
>>> +    if ( copyback && __copy_to_guest(u_domctl, domctl, 1) )
>>> +        rc = -EFAULT;
>> This code is already present in do_domctl (the caller of this function).
>> I wonder if it makes sense to pass a copyback* parameter to
>> arch_do_domctl and just rely on the caller's exit path.
> Could do, cc-ing Jan in addition to Andy for x86 perspective (since this
> would be a generic change.

+1

~Andrew