From: Daniel De Graaf <dgdegra@tycho.nsa.gov>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>
Cc: wei.liu2@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] flask: Allow device model to raise PCI interrupts (pcilevel capability)
Date: Tue, 15 Dec 2015 16:34:48 -0500 [thread overview]
Message-ID: <56708778.7010309@tycho.nsa.gov> (raw)
In-Reply-To: <22126.45202.457324.51326@mariner.uk.xensource.com>
On 14/12/15 07:05, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH] flask: Allow device model to raise PCI interrupts (pcilevel capability)"):
> ...
>> - allow $1 $2_target:hvm { getparam setparam trackdirtyvram hvmctl irqlevel pciroute cacheattr send_irq };
>> + allow $1 $2_target:hvm { getparam setparam trackdirtyvram hvmctl irqlevel pciroute pcilevel cacheattr send_irq };
>
> Thanks for tracking this down.
>
> Based on xen/xsm/flask/policy/access_vectors this seems like a
> no-brainer. Hopefully Daniel will agree :-).
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
> Ian.
Yep, this change is obvious given the issue. I didn't find any other
missing XSM_DM_PRIV accesses when I walked through them, so hopefully
this is the only one that wasn't correct.
Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
next prev parent reply other threads:[~2015-12-15 21:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-14 11:55 [PATCH] flask: Allow device model to raise PCI interrupts (pcilevel capability) Ian Campbell
2015-12-14 12:05 ` Ian Jackson
2015-12-15 21:34 ` Daniel De Graaf [this message]
2015-12-16 10:21 ` Ian Campbell
2015-12-19 3:11 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56708778.7010309@tycho.nsa.gov \
--to=dgdegra@tycho.nsa.gov \
--cc=Ian.Jackson@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).