From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel De Graaf Subject: Re: [PATCH] flask: Allow device model to raise PCI interrupts (pcilevel capability) Date: Tue, 15 Dec 2015 16:34:48 -0500 Message-ID: <56708778.7010309@tycho.nsa.gov> References: <1450094145-31794-1-git-send-email-ian.campbell@citrix.com> <22126.45202.457324.51326@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <22126.45202.457324.51326@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , Ian Campbell Cc: wei.liu2@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 14/12/15 07:05, Ian Jackson wrote: > Ian Campbell writes ("[PATCH] flask: Allow device model to raise PCI interrupts (pcilevel capability)"): > ... >> - allow $1 $2_target:hvm { getparam setparam trackdirtyvram hvmctl irqlevel pciroute cacheattr send_irq }; >> + allow $1 $2_target:hvm { getparam setparam trackdirtyvram hvmctl irqlevel pciroute pcilevel cacheattr send_irq }; > > Thanks for tracking this down. > > Based on xen/xsm/flask/policy/access_vectors this seems like a > no-brainer. Hopefully Daniel will agree :-). > > Acked-by: Ian Jackson > > Ian. Yep, this change is obvious given the issue. I didn't find any other missing XSM_DM_PRIV accesses when I walked through them, so hopefully this is the only one that wasn't correct. Acked-by: Daniel De Graaf