From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Subject: Re: [PATCH 5/9] xenstore: modify init-xenstore-domain
 parameter syntax
Date: Tue, 15 Dec 2015 16:49:47 -0500
Message-ID: <56708AFB.7080903@tycho.nsa.gov>
References: <1449848861-7700-1-git-send-email-jgross@suse.com>
	<1449848861-7700-6-git-send-email-jgross@suse.com>
	<1450182151.16856.156.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1450182151.16856.156.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, Juergen Gross <jgross@suse.com>, xen-devel@lists.xen.org, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com, wei.liu2@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 15/12/15 07:22, Ian Campbell wrote:
> +Daniel
> On Fri, 2015-12-11 at 16:47 +0100, Juergen Gross wrote:
>> init-xenstore-domain takes only positional parameters today. Change
>> this to a more flexible parameter syntax allowing to specify additional
>> options or to omit some.
>>
>> Today the supported usage is:
>>
>> init-xenstore-domain <xenstore-kernel> <memory_mb> <flask-label>
>>                       [<ramdisk-file>]
>>
>> Modify this to:
>>
>> init-xenstore-domain --kernel <xenstore-kernel>
>>                       --memory <memory_mb>
>>                       [--flask <flask-label>]
>>                       [--ramdisk <ramdisk-file>]
>>
>> The flask label is made optional in order to support xenstore domains
>> without the need of a flask enabled hypervisor.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>
> Looks fine to me
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> I'd like to see Daniel opinion of all the changes to init-xenstore-domain.c
> in this series though.

This and the other command line changes in #7 look good, and make the
rather opaque invocation of the tool a bit nicer to read.

Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>