From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel De Graaf Subject: Re: [PATCH 4/9] xenstore: add error messages to init-xenstore-domain Date: Tue, 15 Dec 2015 16:54:51 -0500 Message-ID: <56708C2B.1010202@tycho.nsa.gov> References: <1449848861-7700-1-git-send-email-jgross@suse.com> <1449848861-7700-5-git-send-email-jgross@suse.com> <1450182027.16856.155.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1450182027.16856.155.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Juergen Gross , xen-devel@lists.xen.org, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com, wei.liu2@citrix.com List-Id: xen-devel@lists.xenproject.org On 15/12/15 07:20, Ian Campbell wrote: > Adding Daniel again. > > On Fri, 2015-12-11 at 16:47 +0100, Juergen Gross wrote: >> Additional add some diagnostic messages to the program to have an idea >> why it failed. > [...] >> err: >> if (dom) >> xc_dom_release(dom); >> + if (domid >= 0) >> + xc_domain_destroy(xch, domid); > > This important looking bug fix should't be buried in this otherwise quite > mechanical commit. > > The rest looks reasonable, so with the above moved to a separate commit > this one would be: > Acked-by: Ian Campbell > > Ian. Both parts of the fix look good, split or together (but I agree that splitting is better for the history). Either way: Acked-by: Daniel De Graaf