From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Subject: Re: [PATCH XEN v7 27/29] tools/libs/*: Use O_CLOEXEC on Linux and FreeBSD Date: Wed, 16 Dec 2015 13:37:12 +0100 Message-ID: <56715AF8.4070601@citrix.com> References: <1450269007.4053.48.camel@citrix.com> <1450269096-27598-1-git-send-email-ian.campbell@citrix.com> <1450269096-27598-28-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1450269096-27598-28-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org Cc: jbeulich@suse.com List-Id: xen-devel@lists.xenproject.org El 16/12/15 a les 13.31, Ian Campbell ha escrit: > In some cases this replaces an FD_CLOEXEC dance, in others it is new. > = > Linux has had O_CLOEXEC since 2.6.23 (October 2007), so we can rely on > it from Xen 4.7 I think. Some libc headers may still lack the > definition, so we take care of that if need be. > = > All stable versions of FreeBSD support O_CLOEXEC (10.2, 9.3 and 8.4), > and we assume the libc there does too. Yes, the FreeBSD libc certainly does, since the kernel and libc are tied together in the BSD world (ie: they live in the same repository). > = > Remove various comments about having to take responsibility for this > (since really it is just hygiene, politeness, not a requirement) and > the reasons for using O_CLOEXEC seem pretty straightforward. > = > Backends for other OSes are untouched. > = > Signed-off-by: Ian Campbell For the FreeBSD side: Acked-by: Roger Pau Monn=E9