From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v3 1/6] xl: Return proper error codes for block-attach and block-detach Date: Wed, 16 Dec 2015 16:53:49 +0000 Message-ID: <5671971D.9070404@citrix.com> References: <1448970835-2706-1-git-send-email-george.dunlap@eu.citrix.com> <1449594928.16124.122.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1449594928.16124.122.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , George Dunlap , xen-devel@lists.xen.org Cc: Ian Jackson , Wei Liu List-Id: xen-devel@lists.xenproject.org On 08/12/15 17:15, Ian Campbell wrote: > On Tue, 2015-12-01 at 11:53 +0000, George Dunlap wrote: >> Return proper error codes on failure so that scripts can tell whether >> the command completed properly or not. >> >> Also while we're at it, normalize init and dispose of >> libxl_device_disk structures. This means calling init and dispose in >> the actual functions where they are declared. >> >> This in turn means changing parse_disk_config_multistring() to not >> call libxl_device_disk_init. And that in turn means changes to >> callers of parse_disk_config(). >> >> It also means removing libxl_device_disk_init() from >> libxl.c:libxl_vdev_to_device_disk(). This is only called from >> xl_cmdimpl.c. > > ... and the ocaml bindings. > > I can't remember what we decided regarding libxl "getter" functions and > initialisation of the data type (i.e. whose responsibility it is), but it > seems that changing a given calls semantics is rather dangerous API-wise. Right -- looks like there are similar issues with the nic lookup routines as well. I'll drop that bit from the patch. -George