From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH] x86/vPMU: constrain MSR_IA32_DS_AREA loads
Date: Thu, 17 Dec 2015 09:41:57 -0500
Message-ID: <5672C9B5.8090508@oracle.com>
References: <5672CE4002000078000C0C7D@prv-mh.provo.novell.com>
	<5672C2C6.9020808@oracle.com>
	<5672D24802000078000C0CB7@prv-mh.provo.novell.com>
	<5672C60E.3010303@oracle.com>
	<5672D4DB02000078000C0CD5@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <boris.ostrovsky@oracle.com>) id 1a9Zkn-0003WI-8F
	for xen-devel@lists.xenproject.org; Thu, 17 Dec 2015 14:42:01 +0000
In-Reply-To: <5672D4DB02000078000C0CD5@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>, Jun Nakajima <jun.nakajima@intel.com>, xen-devel <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

On 12/17/2015 09:29 AM, Jan Beulich wrote:
>>>> On 17.12.15 at 15:26, <boris.ostrovsky@oracle.com> wrote:
>> On 12/17/2015 09:18 AM, Jan Beulich wrote:
>>>>>> On 17.12.15 at 15:12, <boris.ostrovsky@oracle.com> wrote:
>>>> On 12/17/2015 09:01 AM, Jan Beulich wrote:
>>>>> @@ -415,8 +416,10 @@ static int core2_vpmu_verify(struct vcpu
>>>>>                 enabled_cntrs |= (1ULL << i);
>>>>>         }
>>>>>     
>>>>> -    if ( vpmu_is_set(vcpu_vpmu(v), VPMU_CPU_HAS_DS) &&
>>>>> -         !is_canonical_address(core2_vpmu_cxt->ds_area) )
>>>>> +    if ( vpmu_is_set(vpmu, VPMU_CPU_HAS_DS) &&
>>>>> +         !(has_hvm_container_vcpu(v)
>>>>> +           ? is_canonical_address(core2_vpmu_cxt->ds_area)
>>>>> +           : __addr_ok(core2_vpmu_cxt->ds_area)) )
>>>> Should we instead of (or in addition to) this also make the same change
>>>> in core2_vpmu_do_wrmsr()?
>>> Currently there's no need for this since - afaict - PV guests can't
>>> write this MSR directly (it's not among the white listed set in
>>> traps.c).
>> Then we probably shouldn't set VPMU_CPU_HAS_DS for PV guests.
> Or add the MSR to the permitted set. You know better than I
> what the best route here is.

I vaguely recall a conversation where we weren't sure whether BTS (which 
needs DS area) will work for PV. Something to do with DS address being 
in the right context (guest or host). I'd need to find that conversation 
(or test BTS on PV).

-boris