From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Doug Goldstein <cardoe@cardoe.com>, xen-devel@lists.xen.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
Daniel De Graaf <dgdegra@tycho.nsa.gov>,
Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] tools: make flask utils build unconditional
Date: Tue, 22 Dec 2015 11:51:33 +0000 [thread overview]
Message-ID: <56793945.6060306@citrix.com> (raw)
In-Reply-To: <1450759603-24249-1-git-send-email-cardoe@cardoe.com>
On 22/12/15 04:46, Doug Goldstein wrote:
> The flask utilities only have dependencies on libxc so there's no
> downside to always building it. Distros and projects based on Xen can
> put these utilities into a different package and not install them for
> everyone. Prior to this change FLASK_ENABLE needs to be a top level
> variable however after this change FLASK_ENABLE only affects xen/.
>
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
CC'ing Daniel as this is a flask related change.
FWIW, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> tools/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/Makefile b/tools/Makefile
> index 820ca40..2f773fd 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -4,7 +4,7 @@ include $(XEN_ROOT)/tools/Rules.mk
> SUBDIRS-y :=
> SUBDIRS-y += include
> SUBDIRS-y += libxc
> -SUBDIRS-$(FLASK_ENABLE) += flask
> +SUBDIRS-y += flask
> SUBDIRS-y += xenstore
> SUBDIRS-y += misc
> SUBDIRS-y += examples
next prev parent reply other threads:[~2015-12-22 11:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 4:46 [PATCH] tools: make flask utils build unconditional Doug Goldstein
2015-12-22 11:51 ` Andrew Cooper [this message]
2015-12-22 21:26 ` [PATCH 1/2] xen: convert FLASK_ENABLE to Kconfig Doug Goldstein
2015-12-22 21:26 ` [PATCH 2/2] xen: convert XSM_ENABLE " Doug Goldstein
2015-12-22 21:37 ` Andrew Cooper
2016-01-04 20:01 ` Daniel De Graaf
2016-01-04 20:33 ` Doug Goldstein
2016-01-04 20:47 ` Daniel De Graaf
2016-01-05 3:06 ` [PATCH v2 " Doug Goldstein
2016-01-11 11:44 ` Ian Jackson
2016-01-04 20:01 ` [PATCH 1/2] xen: convert FLASK_ENABLE " Daniel De Graaf
2016-01-04 12:28 ` [PATCH] tools: make flask utils build unconditional Wei Liu
2016-01-04 14:14 ` Doug Goldstein
2016-01-04 14:26 ` Wei Liu
2016-01-05 14:37 ` Ian Campbell
2016-01-05 15:36 ` Ian Campbell
2016-01-05 16:13 ` Wei Liu
2016-01-05 16:24 ` Ian Campbell
2016-01-05 16:42 ` Wei Liu
2016-01-08 18:49 ` Doug Goldstein
2016-01-11 15:19 ` Wei Liu
2016-01-11 17:10 ` Doug Goldstein
2016-01-12 16:09 ` Wei Liu
2016-01-05 16:34 ` Doug Goldstein
2016-01-05 16:41 ` Ian Campbell
-- strict thread matches above, loose matches on Subject: below --
2016-01-15 17:39 [PATCH] tools: make FLASK " Doug Goldstein
2016-01-15 19:48 ` Andrew Cooper
2016-01-18 12:10 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56793945.6060306@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).