From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 2/2] vm_event: Add altp2m info to HVM events as well Date: Wed, 6 Jan 2016 11:48:24 +0000 Message-ID: <568CFF08.2050808@citrix.com> References: <1450882432-10484-1-git-send-email-tamas@tklengyel.com> <1450882432-10484-2-git-send-email-tamas@tklengyel.com> <568D094302000078000C3E1D@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6461582691997080049==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aGmZq-0006co-7j for xen-devel@lists.xenproject.org; Wed, 06 Jan 2016 11:48:30 +0000 In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel , Jan Beulich Cc: Xen-devel , Keir Fraser , Razvan Cojocaru List-Id: xen-devel@lists.xenproject.org --===============6461582691997080049== Content-Type: multipart/alternative; boundary="------------040101090504020305030507" --------------040101090504020305030507 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit On 06/01/16 11:42, Tamas K Lengyel wrote: > > > On Wed, Jan 6, 2016 at 12:32 PM, Jan Beulich > wrote: > > >>> On 23.12.15 at 15:53, > wrote: > > @@ -83,6 +84,12 @@ static int hvm_event_traps(uint8_t sync, > vm_event_request_t *req) > > vm_event_vcpu_pause(curr); > > } > > > > + if ( altp2m_active(currd) ) > > + { > > + req->flags |= VM_EVENT_FLAG_ALTERNATE_P2M; > > + req->altp2m_idx = vcpu_altp2m(curr).p2midx; > > + } > > So far this info was provided just for MEM_ACCESS events. Now > you provide it for a few more ones, but wouldn't this then better > be supplied for all of them, namely also the other two MEM ones? > > > AFAIK altp2m is currently incompatible with sharing. I'm not 100% sure > but I think it's also incompatible with paging. I don't think they are strictly incompatible; I don't see a technical reason preventing some development work to make them function together. Whether this happens or not is a very different matter. ~Andrew --------------040101090504020305030507 Content-Type: text/html; charset="utf-8" Content-Length: 2941 Content-Transfer-Encoding: quoted-printable
On 06/01/16 11:42, Tamas K Lengyel wrote:


On Wed, Jan 6, 2016 at 12:32 PM, Jan Beulich <JBeulich@suse.com> wrote:
>>> On 23.12.15 at 15:53, <tamas@tklengyel.com> wrote:
> @@ -83,6 +84,12 @@ static int hvm_event_traps(uint8_t sync, vm_event_request_t *req)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 vm_event_vcpu_pause(curr);
>=C2=A0 =C2=A0 =C2=A0 }
>
> +=C2=A0 =C2=A0 if ( altp2m_active(currd) )
> +=C2=A0 =C2=A0 {
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 req->flags |=3D VM_EVENT_FLAG_ALTERNATE_P2M;
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 req->altp2m_idx =3D vcpu_altp2m(curr).p2midx;
> +=C2=A0 =C2=A0 }

So far this info was provided just for MEM_ACCESS events. Now
you provide it for a few more ones, but wouldn't this then better
be supplied for all of them, namely also the other two MEM ones=3F

AFAIK altp2m is currently incompatible with sharing. I'm not 100% sure but I think it's also incompatible with paging.

I don't think they are strictly incompatible; I don't see a technical reason preventing some development work to make them function together.

Whether this happens or not is a very different matter.

~Andrew --------------040101090504020305030507-- --===============6461582691997080049== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6461582691997080049==--