From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH v2 04/13] xenstore: move init-xenstore-domain to tools/helpers Date: Thu, 7 Jan 2016 07:12:09 +0100 Message-ID: <568E01B9.6070706@suse.com> References: <1450444471-6454-1-git-send-email-jgross@suse.com> <1450444471-6454-5-git-send-email-jgross@suse.com> <1452096208.21055.102.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1452096208.21055.102.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , xen-devel@lists.xen.org, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com, wei.liu2@citrix.com, dgdegra@tycho.nsa.gov List-Id: xen-devel@lists.xenproject.org On 06/01/16 17:03, Ian Campbell wrote: > On Fri, 2015-12-18 at 14:14 +0100, Juergen Gross wrote: >> The program init-xenstore-domain to start a xenstore domain instead >> of the xenstored daemon is built, but not installed. Change that. >> >> Move the program to a new tools subdirectory "helpers" to be able to >> use libxl in a later patch. Otherwise a dependency loop will be >> created. >> >> While moving modify the coding style to the standard style used in >> the tools directory. > > Please don't combine such things with moving the whole file. Or at the very > least please use git send-email/format-patch -M (ideally both do it > separately and use -M). Okay, I'll do the move in this patch only. > So long as the file is self consistent I'm not convinced it is actually > worth changing, plus it doesn't actually seem to be following CODING_STYLE > (which is the default style for tools/* as well as xen/*), since hasn't > gained e.g. spaces inside of the if ( x ). As there are substantial changes to this file in later patches, I'll do the coding style changes in a separate patch, using the _correct_ style. Juergen