From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH v3 2/4] libxc: support of linear p2m list for migration of pv-domains Date: Thu, 7 Jan 2016 11:37:15 +0100 Message-ID: <568E3FDB.3020308@suse.com> References: <1450257860-11389-1-git-send-email-jgross@suse.com> <1450257860-11389-3-git-send-email-jgross@suse.com> <20160106154009.GJ27789@citrix.com> <568E3C10.5040305@suse.com> <20160107103350.GU27789@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160107103350.GU27789@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: andrew.cooper3@citrix.com, xen-devel@lists.xen.org, ian.jackson@eu.citrix.com, Ian.Campbell@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 07/01/16 11:33, Wei Liu wrote: > On Thu, Jan 07, 2016 at 11:21:04AM +0100, Juergen Gross wrote: >> On 06/01/16 16:40, Wei Liu wrote: >>> On Wed, Dec 16, 2015 at 10:24:18AM +0100, Juergen Gross wrote: >>> [...] >>>> @@ -698,21 +868,19 @@ static int normalise_pagetable(struct xc_sr_context *ctx, const uint64_t *src, >>>> /* 32bit guests can only use the first 4 entries of their L3 tables. >>>> * All other are potentially used by Xen. */ >>>> xen_first = 4; >>>> - xen_last = 512; >>>> + xen_last = 511; >>> >>> Is this a bug fix in its own right? >> >> Hmm, bug fix is too much. It is a harmonization with the change below >> using macros to set xen_last to 511 at maximum. In fact it doesn't >> matter, because xen_last is used in: >> >> if ( i >= xen_first && i <= xen_last ) >> >> with i being in the range from 0 to 511. >> > > Yes, that's what I was thinking. There seemed to be an off-by-one error > in the code. But as you said, i is within [0,511] so the code is fine. > > Could you add a words or two about this hunk in commit message please. Sure. > > With that: > > Reviewed-by: Wei Liu Thanks, Juergen