From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH v4 2/3] public/io/netif.h: document control
 ring and toeplitz hashing
Date: Fri, 8 Jan 2016 16:22:57 +0000
Message-ID: <568FE261.7030403@citrix.com>
References: <1452171912-29857-1-git-send-email-paul.durrant@citrix.com>
	<1452171912-29857-3-git-send-email-paul.durrant@citrix.com>
	<568FDEBE.6030502@citrix.com>
	<92ebfa832769474786a774948717ae79@AMSPEX02CL03.citrite.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=808351040=david.vrabel@citrix.com>)
	id 1aHZpY-0007So-4v
	for xen-devel@lists.xenproject.org; Fri, 08 Jan 2016 16:24:00 +0000
In-Reply-To: <92ebfa832769474786a774948717ae79@AMSPEX02CL03.citrite.net>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Paul Durrant <Paul.Durrant@citrix.com>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Tim (Xen.org)" <tim@xen.org>, "Keir (Xen.org)" <keir@xen.org>, Ian Campbell <Ian.Campbell@citrix.com>, Jan Beulich <jbeulich@suse.com>, Ian Jackson <Ian.Jackson@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 08/01/16 16:21, Paul Durrant wrote:
>> -----Original Message-----
>> From: David Vrabel [mailto:david.vrabel@citrix.com]
>> Sent: 08 January 2016 16:07
>> To: Paul Durrant; xen-devel@lists.xenproject.org
>> Cc: Keir (Xen.org); Ian Campbell; Tim (Xen.org); Ian Jackson; Jan Beulich
>> Subject: Re: [Xen-devel] [PATCH v4 2/3] public/io/netif.h: document control
>> ring and toeplitz hashing
>>
>> On 07/01/16 13:05, Paul Durrant wrote:
>>> This patch documents a new shared ring between frontend and backend
>> that
>>> can be used to pass bulk out-of-band data, such as that required to
>>> implement toeplitz hashing in the backend such that it is configurable by
>>> the frontend.
>>>
>>> The patch then goes on to document the messages passed over the control
>>> ring that can be used to configure toeplitz hashing.
>> [...]
>>> --- a/xen/include/public/io/netif.h
>>> +++ b/xen/include/public/io/netif.h
>>> @@ -151,6 +151,270 @@
>>>   */
>>>
>>>  /*
>>> + * Control ring
>>> + * ============
>> [...]
>>> + * The frontend provides a control ring to the backend by setting:
>>> + *
>>> + * /local/domain/<domid>/device/vif/<vif>/ctrl-ring-ref = <gref>
>>> + * /local/domain/<domid>/device/vif/<vif>/event-channel-ctrl = <port>
>>
>> ctrl-event-channel to match ctrl-ring-ref?
>>
> 
> I was following the style of the tx and rx rings where it is 'blah-ring-ref' and 'event-channel-blah'. Do you think I should break precedent?

I hadn't noticed that.  Either way is fine by me then.

David