From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v4 2/5] build: Hook the schedulers into
 Kconfig
Date: Sat, 9 Jan 2016 14:52:26 +0000
Message-ID: <56911EAA.8030707@citrix.com>
References: <1452288166-43501-1-git-send-email-jonathan.creekmore@gmail.com>
	<1452288166-43501-3-git-send-email-jonathan.creekmore@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=8095139d5=Andrew.Cooper3@citrix.com>)
	id 1aHusb-0004qX-P7
	for xen-devel@lists.xenproject.org; Sat, 09 Jan 2016 14:52:33 +0000
In-Reply-To: <1452288166-43501-3-git-send-email-jonathan.creekmore@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jonathan Creekmore <jonathan.creekmore@gmail.com>, xen-devel@lists.xenproject.org
Cc: George Dunlap <george.dunlap@eu.citrix.com>, Dario Faggioli <dario.faggioli@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 08/01/16 21:22, Jonathan Creekmore wrote:
> +# Enable schedulers
> +menu "Schedulers"
> +	visible if EXPERT = "y"
> +
> +config SCHED_CREDIT
> +	bool "Credit scheduler support"
> +	default y
> +	---help---
> +	  The traditional credit scheduler is a general purpose scheduler.
> +
> +	  If unsure, say Y.
> +
> +config SCHED_CREDIT2
> +	bool "Credit2 scheduler support (EXPERIMENTAL)"
> +	default y
> +	---help---
> +	  The credit2 scheduler is a general purpose scheduler that is
> +	  optimized for lower latency and higher VM density.
> +
> +	  If unsure, say Y.
> +
> +config SCHED_RTDS
> +	bool "RTDS scheduler support (EXPERIMENTAL)"
> +	default y
> +	---help---
> +	  The RTDS scheduler is a soft and firm real-time scheduler for
> +	  multicore, targeted for embedded, automotive, graphics and gaming
> +	  in the cloud, and general low-latency workloads.
> +
> +	  If unsure, say N.
> +
> +config SCHED_ARINC653
> +	bool "ARINC653 scheduler support (EXPERIMENTAL)"
> +	default y
> +	---help---
> +	  The ARINC653 scheduler is a hard real-time scheduler for single
> +	  cores, targeted for avionics, drones, and medical devices.
> +
> +	  If unsure, say N.

Sorry for not noticing this before.  The "If unsure, say $X" should
really match the default value.

On the other hand, given that we are hiding all these options behind
CONFIG_EXPERT, I am not sure that we need "If unsure" clauses.  Anyone
who isn't sure shouldn't have turned on CONFIG_EXPERT to start with.

~Andrew