From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] xen/spinlock: Use mnemonics for recursive
 spinlock sentinel values
Date: Mon, 11 Jan 2016 15:35:48 +0000
Message-ID: <5693CBD4.60806@citrix.com>
References: <1452350038-29323-1-git-send-email-andrew.cooper3@citrix.com>
	<5693C80C02000078000C5716@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5693C80C02000078000C5716@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Tim Deegan <tim@xen.org>, Doug Goldstein <cardoe@cardoe.com>, Ian Campbell <Ian.Campbell@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 11/01/16 14:19, Jan Beulich wrote:
>>>> On 09.01.16 at 15:33, <andrew.cooper3@citrix.com> wrote:
>> --- a/xen/common/spinlock.c
>> +++ b/xen/common/spinlock.c
>> @@ -246,7 +246,7 @@ int _spin_trylock_recursive(spinlock_t *lock)
>>      unsigned int cpu = smp_processor_id();
>>  
>>      /* Don't allow overflow of recurse_cpu field. */
>> -    BUILD_BUG_ON(NR_CPUS > 0xfffu);
>> +    BUILD_BUG_ON(NR_CPUS >= SPINLOCK_NO_CPU);
> ">" (see also the reply to Doug's patch 1/2)

So it is.

As there is no bug, I will resubmit the cleanup when the NR_CPUS series
is in to avoid causing patch conflicts.

~Andrew