From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 1/5] xen/elfnotes: initialise phys_entry to UNSET_ADDR32 Date: Wed, 13 Jan 2016 13:10:07 +0000 Message-ID: <56964CAF.5010205@citrix.com> References: <1452688338-70075-1-git-send-email-roger.pau@citrix.com> <1452688338-70075-2-git-send-email-roger.pau@citrix.com> <5696553302000078000C649D@prv-mh.provo.novell.com> <56964881.9000707@citrix.com> <5696590E02000078000C64F7@prv-mh.provo.novell.com> <56964BA4.5050701@citrix.com> <56965A6A02000078000C6516@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aJLBo-0007Pa-SK for xen-devel@lists.xenproject.org; Wed, 13 Jan 2016 13:10:16 +0000 In-Reply-To: <56965A6A02000078000C6516@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Ian Jackson , xen-devel@lists.xenproject.org, Wei Liu , Ian Campbell , roger.pau@citrix.com List-Id: xen-devel@lists.xenproject.org On 13/01/16 13:08, Jan Beulich wrote: >>>> On 13.01.16 at 14:05, wrote: >> On 13/01/16 13:02, Jan Beulich wrote: >>>>>> On 13.01.16 at 13:52, wrote: >>>> El 13/01/16 a les 13.46, Jan Beulich ha escrit: >>>>>>>> On 13.01.16 at 13:32, wrote: >>>>>> tools/libxc/xc_dom_elfloader.c | 2 +- >>>>>> xen/common/libelf/libelf-dominfo.c | 1 + >>>>>> xen/include/xen/libelf.h | 1 + >>>>>> 3 files changed, 3 insertions(+), 1 deletion(-) >>>>> With this diffstat, any reason only tools maintainers got Cc-ed? >>>> Hm, weird, that's what scripts/get_maintainer.pl gave me as output. >>> Something must be broken there. >> There is not an entry covering xen/common. > And hence for those file it should fall back to THE REST. Per original review, THE REST is only invoked on a patch which doesn't match any paths. As one file matched toolstack, THE REST wasn't invoked. There really should be a xen/ entry. ~Andrew