From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>,
Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>, suravee.suthikulpanit@amd.com
Subject: Re: [PATCH] x86emul: support clzero
Date: Wed, 13 Jan 2016 15:10:59 +0000 [thread overview]
Message-ID: <56966903.8030209@citrix.com> (raw)
In-Reply-To: <5693D066.6070607@amd.com>
On 11/01/16 15:55, Aravind Gopalakrishnan wrote:
> On 9/22/2015 8:06 AM, Jan Beulich wrote:
>> ... in anticipation of this possibly going to get used by guests for
>> basic thinks like memset() or clearing or pages.
>>
>> Since the emulation doesn't use clzero itself, checking the guest's
>> CPUID for the feature to be exposed is (intentionally) being avoided
>> here. All that's required is sensible guest side data for the clflush
>> line size.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>
>>
>
> Reviewed-by: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
I would still like to see some instruction documentation as the soonest
possible opportunity, to give the implementation an independent review.
~Andrew
prev parent reply other threads:[~2016-01-13 15:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 13:06 [PATCH] x86emul: support clzero Jan Beulich
2015-09-23 17:37 ` Andrew Cooper
2015-09-24 8:02 ` Jan Beulich
2015-09-24 11:59 ` Andrew Cooper
2015-09-24 12:13 ` Jan Beulich
2015-10-08 10:26 ` Jan Beulich
2016-01-11 15:55 ` Aravind Gopalakrishnan
2016-01-13 15:10 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56966903.8030209@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=aravind.gopalakrishnan@amd.com \
--cc=keir@xen.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).