From: Juergen Gross <jgross@suse.com>
To: Ian Campbell <ian.campbell@citrix.com>, Wei Liu <wei.liu2@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com,
xen-devel@lists.xen.org
Subject: Re: [PATCH v2 3/3] xenstat: handle more than 1024 domains
Date: Fri, 15 Jan 2016 16:39:17 +0100 [thread overview]
Message-ID: <569912A5.7000306@suse.com> (raw)
In-Reply-To: <1452872112.6020.40.camel@citrix.com>
On 15/01/16 16:35, Ian Campbell wrote:
> On Mon, 2016-01-04 at 16:38 +0000, Wei Liu wrote:
>> On Mon, Jan 04, 2016 at 03:55:53PM +0100, Juergen Gross wrote:
>
>>> - dominfo = get_domain_ids(node->handle->xc_handle, &num_doms);
>>> - if (dominfo == NULL)
>>> - return;
>>> + for (;;) {
>>> + num_doms = xc_domain_getinfolist(node->handle-
>>>> xc_handle, next_domid, 1024, dominfo);
>>
>> Some lines have exceeded 80 columns. Not really your fault so no need to
>> resend.
>
> If not the person adding the lines as apparently fresh code then whose
> fault is it?
Clearly mine. I just finished reading Wei's comment after the
"Reviewed-by" tag. Sorry for that.
> These ones seem pretty trivial to wrap correctly so I think I would prefer
> to see them done.
Sure.
> I'll apply #1 and #2 in a moment and expect a resend of this one. Sorry for
> the delay both in applying and commenting, looks like these got buried in
> the post vacation pile.
I thought so. Thanks for doing now.
Juergen
next prev parent reply other threads:[~2016-01-15 15:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 14:55 [PATCH v2 0/3] tools: remove 1024 domain limit at some places Juergen Gross
2016-01-04 14:55 ` [PATCH v2 1/3] libxl: remove the xl list limit of 1024 domains Juergen Gross
2016-01-04 16:38 ` Wei Liu
2016-01-04 14:55 ` [PATCH v2 2/3] libxl: base libxl_list_vm() on libxl_list_domain() Juergen Gross
2016-01-04 16:38 ` Wei Liu
2016-01-04 14:55 ` [PATCH v2 3/3] xenstat: handle more than 1024 domains Juergen Gross
2016-01-04 16:38 ` Wei Liu
2016-01-15 15:35 ` Ian Campbell
2016-01-15 15:39 ` Juergen Gross [this message]
2016-01-15 15:03 ` [PATCH v2 0/3] tools: remove 1024 domain limit at some places Juergen Gross
2016-01-15 15:55 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569912A5.7000306@suse.com \
--to=jgross@suse.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).