From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH v2 3/3] xenstat: handle more than 1024 domains Date: Fri, 15 Jan 2016 16:39:17 +0100 Message-ID: <569912A5.7000306@suse.com> References: <1451919353-11547-1-git-send-email-jgross@suse.com> <1451919353-11547-4-git-send-email-jgross@suse.com> <20160104163806.GG12639@citrix.com> <1452872112.6020.40.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1452872112.6020.40.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Wei Liu Cc: stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 15/01/16 16:35, Ian Campbell wrote: > On Mon, 2016-01-04 at 16:38 +0000, Wei Liu wrote: >> On Mon, Jan 04, 2016 at 03:55:53PM +0100, Juergen Gross wrote: > >>> - dominfo = get_domain_ids(node->handle->xc_handle, &num_doms); >>> - if (dominfo == NULL) >>> - return; >>> + for (;;) { >>> + num_doms = xc_domain_getinfolist(node->handle- >>>> xc_handle, next_domid, 1024, dominfo); >> >> Some lines have exceeded 80 columns. Not really your fault so no need to >> resend. > > If not the person adding the lines as apparently fresh code then whose > fault is it? Clearly mine. I just finished reading Wei's comment after the "Reviewed-by" tag. Sorry for that. > These ones seem pretty trivial to wrap correctly so I think I would prefer > to see them done. Sure. > I'll apply #1 and #2 in a moment and expect a resend of this one. Sorry for > the delay both in applying and commenting, looks like these got buried in > the post vacation pile. I thought so. Thanks for doing now. Juergen