From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] docs: correct descriptions of gnttab_max_{,
 maptrack}_frames
Date: Mon, 18 Jan 2016 13:53:39 +0000
Message-ID: <569CEE63.8080201@citrix.com>
References: <1453123167-22217-1-git-send-email-ian.campbell@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1453123167-22217-1-git-send-email-ian.campbell@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, jbeulich@suse.com, ian.jackson@eu.citrix.com
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 18/01/16 13:19, Ian Campbell wrote:
> gnttab_max_frames incorrectly referred to numbers of grant tab
> operations and gnttab_max_maptrack_frames was confusingly worded.
>
> Add the default for gnttab_max_frames while here (it's currently the
> same on all arches since no arch uses the available arch override).
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> ---
>  docs/misc/xen-command-line.markdown | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/docs/misc/xen-command-line.markdown b/docs/misc/xen-command-line.markdown
> index 5ed0730..8d46892 100644
> --- a/docs/misc/xen-command-line.markdown
> +++ b/docs/misc/xen-command-line.markdown
> @@ -740,13 +740,14 @@ Specify which console gdbstub should use. See **console**.
>  ### gnttab\_max\_frames
>  > `= <integer>`

> Default: `32`

Is the prevailing style for indicating defaults.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

>  
> -Specify the maximum number of frames per grant table operation.
> +Specify the maximum number of frames which any domain may use as part
> +of its grant table. The default value is 32.
>  
>  ### gnttab\_max\_maptrack\_frames
>  > `= <integer>`
>  
> -Specify the maximum number of maptrack frames domain.
> -The default value is 8 times **gnttab\_max\_frames**.
> +Specify the maximum number of frames to use as part of a domains
> +maptrack array. The default value is 8 times **gnttab\_max\_frames**.
>  
>  ### gnttab\_max\_nr\_frames
>  > `= <integer>`