From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shannon Zhao Subject: Re: [PATCH v4 09/10] arm/uart: Rename dt-uart.c to arm-uart.c Date: Tue, 19 Jan 2016 16:43:08 +0800 Message-ID: <569DF71C.1040809@huawei.com> References: <1452920477-13916-1-git-send-email-zhaoshenglong@huawei.com> <1452920477-13916-10-git-send-email-zhaoshenglong@huawei.com> <569CCF1102000078000C7E68@prv-mh.provo.novell.com> <569DAF25.1040303@huawei.com> <569E043D02000078000C853E@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <569E043D02000078000C853E@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: ian.campbell@citrix.com, peter.huangpeng@huawei.com, xen-devel@lists.xen.org, julien.grall@citrix.com, stefano.stabellini@citrix.com, shannon.zhao@linaro.org List-Id: xen-devel@lists.xenproject.org On 2016/1/19 16:39, Jan Beulich wrote: >>>> On 19.01.16 at 04:36, wrote: >> > >> > On 2016/1/18 18:40, Jan Beulich wrote: >>>>>> >>>>> On 16.01.16 at 06:01, wrote: >>>>> >>> > From: Shannon Zhao >>>>> >>> > >>>>> >>> > Since we will add ACPI initialization for UART in this file later, >>>>> >>> > rename it with a generic name. >>>>> >>> > >>>>> >>> > Signed-off-by: Shannon Zhao >>>>> >>> > --- >>>>> >>> > v4: split the original patch to renaming this and adding ACPI parts. >>>>> >>> > --- >>>>> >>> > MAINTAINERS | 2 +- >>>>> >>> > xen/drivers/char/Makefile | 2 +- >>>>> >>> > xen/drivers/char/arm-uart.c | 107 ++++++++++++++++++++++++++++++++++++++++++++ >>>>> >>> > xen/drivers/char/dt-uart.c | 107 -------------------------------------------- >>>>> >>> > 4 files changed, 109 insertions(+), 109 deletions(-) >>>>> >>> > create mode 100644 xen/drivers/char/arm-uart.c >>>>> >>> > delete mode 100644 xen/drivers/char/dt-uart.c >>> >> Looks like this really is a rename with little actual changes to >>> >> the file, >> > Yes, but the only change to this file is also to change its name because >> > it's mentioned in the file header. This intends to make that consistent. >> > >> > + * xen/drivers/char/arm-uart.c > I understand that, but without using git's ability to represent the > rename such that the diff between the files is visible it is hard to > tell what exactly you changed in the file. Yes, from the git diffstat it's hard to tell the truth. I will add some words in the commit message. Thanks, -- Shannon