From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3] x86/HVM: add padding to struct hvm_hw_cpu
Date: Tue, 19 Jan 2016 16:21:14 +0100 [thread overview]
Message-ID: <569E546A.7040307@citrix.com> (raw)
In-Reply-To: <569E60B102000078000C8B2C@prv-mh.provo.novell.com>
El 19/01/16 a les 16.13, Jan Beulich ha escrit:
>>>> On 18.01.16 at 17:25, <roger.pau@citrix.com> wrote:
>> --- a/xen/arch/x86/hvm/hvm.c
>> +++ b/xen/arch/x86/hvm/hvm.c
>> @@ -1990,6 +1990,9 @@ static int hvm_load_cpu_ctxt(struct domain *d, hvm_domain_context_t *h)
>> if ( hvm_load_entry_zeroextend(CPU, h, &ctxt) != 0 )
>> return -EINVAL;
>>
>> + if ( ctxt.pad0 != 0 )
>> + return -EINVAL;
>
> Right after I had committed and pushed the patch it occurred to
> me that this seems to be missing a save side counterpart, which
> would constitute both an information leak and a functional bug.
> Would you please take another look?
Sure, thanks for realising! Now that you make me look at it
hvm_save_cpu_ctxt should zero hvm_hw_cpu on each iteration, IMHO the
current code is asking for trouble. I will send a patch ASAP.
Roger.
prev parent reply other threads:[~2016-01-19 15:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 12:10 [xen-unstable test] 78395: regressions - FAIL osstest service owner
2016-01-18 12:55 ` Jan Beulich
2016-01-18 14:39 ` [PATCH] x86/HVM: add padding to hvm_hw_cpu Roger Pau Monne
2016-01-18 14:47 ` Andrew Cooper
2016-01-18 15:09 ` [PATCH v2] x86/HVM: change the flags cpu context field to uint64_t Roger Pau Monne
2016-01-18 15:11 ` Andrew Cooper
2016-01-18 15:21 ` Jan Beulich
2016-01-18 15:24 ` Andrew Cooper
2016-01-18 15:38 ` Roger Pau Monné
2016-01-18 16:24 ` Jan Beulich
2016-01-18 16:33 ` Roger Pau Monné
2016-01-18 16:43 ` Jan Beulich
2016-01-18 15:17 ` [PATCH] x86/HVM: add padding to hvm_hw_cpu Jan Beulich
2016-01-18 16:25 ` [PATCH v3] x86/HVM: add padding to struct hvm_hw_cpu Roger Pau Monne
2016-01-19 15:13 ` Jan Beulich
2016-01-19 15:21 ` Roger Pau Monné [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569E546A.7040307@citrix.com \
--to=roger.pau@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).