Re: [PATCH v2 10/13] xen_hello_world.xsplice: Test payload for patching 'xen_extra_version'.

[Ross Lagerwall <ross.lagerwall@citrix.com>]

On 01/14/2016 09:47 PM, Konrad Rzeszutek Wilk wrote:
snip
> diff --git a/tools/misc/xen_hello_world.c b/tools/misc/xen_hello_world.c
> new file mode 100644
> index 0000000..8c24d8f
> --- /dev/null
> +++ b/tools/misc/xen_hello_world.c
> @@ -0,0 +1,15 @@
> +#include "xsplice.h"
> +
> +/* Our replacement function for xen_extra_version. */
> +const char *xen_hello_world(void)
> +{
> +    return "Hello World";
> +}
> +
> +struct xsplice_patch_func xsplice_hello_world = {
> +    .name = "xen_extra_version",
> +    .new_addr = &xen_hello_world,

This line introduces a warning:
xen_hello_world.c:11:17: warning: initialization makes integer from 
pointer without a cast [-Wint-conversion]
      .new_addr = &xen_hello_world,
                  ^
xen_hello_world.c:11:17: note: (near initialization for 
‘xsplice_hello_world.new_addr’)

-- 
Ross Lagerwall