From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ross Lagerwall <ross.lagerwall@citrix.com>
Subject: Re: [PATCH v2 10/13] xen_hello_world.xsplice: Test
 payload for patching 'xen_extra_version'.
Date: Tue, 19 Jan 2016 16:47:28 +0000
Message-ID: <569E68A0.4010105@citrix.com>
References: <1452808031-706-1-git-send-email-konrad.wilk@oracle.com>
	<1452808031-706-11-git-send-email-konrad.wilk@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; Format="flowed"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=819d94e87=ross.lagerwall@citrix.com>)
	id 1aLZRM-0006QK-GW
	for xen-devel@lists.xenproject.org; Tue, 19 Jan 2016 16:47:32 +0000
In-Reply-To: <1452808031-706-11-git-send-email-konrad.wilk@oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, xen-devel@lists.xenproject.org, mpohlack@amazon.com, andrew.cooper3@citrix.com, stefano.stabellini@citrix.com, jbeulich@suse.com, ian.jackson@eu.citrix.com, ian.campbell@citrix.com, wei.liu2@citrix.com, sasha.levin@oracle.com
List-Id: xen-devel@lists.xenproject.org

On 01/14/2016 09:47 PM, Konrad Rzeszutek Wilk wrote:
snip
> diff --git a/tools/misc/xen_hello_world.c b/tools/misc/xen_hello_world.c
> new file mode 100644
> index 0000000..8c24d8f
> --- /dev/null
> +++ b/tools/misc/xen_hello_world.c
> @@ -0,0 +1,15 @@
> +#include "xsplice.h"
> +
> +/* Our replacement function for xen_extra_version. */
> +const char *xen_hello_world(void)
> +{
> +    return "Hello World";
> +}
> +
> +struct xsplice_patch_func xsplice_hello_world =3D {
> +    .name =3D "xen_extra_version",
> +    .new_addr =3D &xen_hello_world,

This line introduces a warning:
xen_hello_world.c:11:17: warning: initialization makes integer from =

pointer without a cast [-Wint-conversion]
      .new_addr =3D &xen_hello_world,
                  ^
xen_hello_world.c:11:17: note: (near initialization for =

=91xsplice_hello_world.new_addr=92)

-- =

Ross Lagerwall