From mboxrd@z Thu Jan 1 00:00:00 1970 From: Malcolm Crossley Subject: Re: [PATCHv6 1/3] rwlock: Add per-cpu reader-writer lock infrastructure Date: Fri, 22 Jan 2016 14:16:29 +0000 Message-ID: <56A239BD.5040201@citrix.com> References: <1453470107-27861-1-git-send-email-malcolm.crossley@citrix.com> <1453470107-27861-2-git-send-email-malcolm.crossley@citrix.com> <1453470893.4320.85.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aMcWB-0002LP-1y for xen-devel@lists.xenproject.org; Fri, 22 Jan 2016 14:16:51 +0000 In-Reply-To: <1453470893.4320.85.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , JBeulich@suse.com, andrew.cooper3@citrix.com, Marcos.Matsunaga@oracle.com, keir@xen.org, konrad.wilk@oracle.com, george.dunlap@eu.citrix.com Cc: xen-devel@lists.xenproject.org, dario.faggioli@citrix.com, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 22/01/16 13:54, Ian Campbell wrote: > On Fri, 2016-01-22 at 13:41 +0000, Malcolm Crossley wrote: >> >> Changes since v5: >> - Fix compilation on ARM > > This was the removal of some spurious "&", I think? Yeah, I forgot to keep the macro's in sync. ARM also needed the xen/percpu.h header file to be explictly included into spinlock.h. > > Acked-by: Ian Campbell > > Thanks for catching this! Sorry for not build testing before on ARM. Building the hypervisor itself using a prebuilt linaro toolchain is actually very easy (no chroot required). Do you think it's worth documenting this? So that at least hypervisor build failures are caught. Malcolm