From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Lagerwall Subject: Re: [PATCHv6 1/3] rwlock: Add per-cpu reader-writer lock infrastructure Date: Fri, 22 Jan 2016 14:25:28 +0000 Message-ID: <56A23BD8.7010702@citrix.com> References: <1453470107-27861-1-git-send-email-malcolm.crossley@citrix.com> <1453470107-27861-2-git-send-email-malcolm.crossley@citrix.com> <1453470893.4320.85.camel@citrix.com> <56A239BD.5040201@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aMcea-0003qF-HF for xen-devel@lists.xenproject.org; Fri, 22 Jan 2016 14:25:32 +0000 In-Reply-To: <56A239BD.5040201@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Malcolm Crossley Cc: xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 01/22/2016 02:16 PM, Malcolm Crossley wrote: > On 22/01/16 13:54, Ian Campbell wrote: >> On Fri, 2016-01-22 at 13:41 +0000, Malcolm Crossley wrote: >>> >>> Changes since v5: >>> - Fix compilation on ARM >> >> This was the removal of some spurious "&", I think? > > Yeah, I forgot to keep the macro's in sync. ARM also needed the xen/percpu.h header file to be > explictly included into spinlock.h. > >> >> Acked-by: Ian Campbell >> >> Thanks for catching this! > > Sorry for not build testing before on ARM. Building the hypervisor itself using a prebuilt linaro > toolchain is actually very easy (no chroot required). > > Do you think it's worth documenting this? So that at least hypervisor build failures are caught. > This is already documented (briefly) here: http://wiki.xen.org/wiki/Xen_ARM_with_Virtualization_Extensions#Cross_Compiling -- Ross Lagerwall