From mboxrd@z Thu Jan  1 00:00:00 1970
From: Malcolm Crossley <malcolm.crossley@citrix.com>
Subject: Re: [PATCHv6 1/3] rwlock: Add per-cpu reader-writer
 lock infrastructure
Date: Fri, 22 Jan 2016 14:30:32 +0000
Message-ID: <56A23D08.9000608@citrix.com>
References: <1453470107-27861-1-git-send-email-malcolm.crossley@citrix.com>
	<1453470107-27861-2-git-send-email-malcolm.crossley@citrix.com>
	<1453470893.4320.85.camel@citrix.com> <56A239BD.5040201@citrix.com>
	<1453472569.4320.94.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=8226cb754=malcolm.crossley@citrix.com>)
	id 1aMcja-0004di-5M
	for xen-devel@lists.xenproject.org; Fri, 22 Jan 2016 14:30:42 +0000
In-Reply-To: <1453472569.4320.94.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, JBeulich@suse.com, andrew.cooper3@citrix.com, Marcos.Matsunaga@oracle.com, keir@xen.org, konrad.wilk@oracle.com, george.dunlap@eu.citrix.com
Cc: xen-devel@lists.xenproject.org, dario.faggioli@citrix.com, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 22/01/16 14:22, Ian Campbell wrote:
> On Fri, 2016-01-22 at 14:16 +0000, Malcolm Crossley wrote:
>> On 22/01/16 13:54, Ian Campbell wrote:
>>> On Fri, 2016-01-22 at 13:41 +0000, Malcolm Crossley wrote:
>>>>  
>>>> Changes since v5:
>>>> - Fix compilation on ARM
>>>
>>> This was the removal of some spurious "&", I think?
>>
>> Yeah, I forgot to keep the macro's in sync. ARM also needed the
>> xen/percpu.h header file to be
>> explictly included into spinlock.h.
>>
>>>
>>> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>>>
>>> Thanks for catching this!
>>
>> Sorry for not build testing before on ARM.
> 
> No problem, some people never remember at all, so v5 isn't too bad ;-)
> 
>>  Building the hypervisor itself using a prebuilt linaro
>> toolchain is actually very easy (no chroot required).
> 
> Indeed.
> 
>> Do you think it's worth documenting this? So that at least hypervisor
>> build failures are caught.
> 
> I think it's covered by
> http://wiki.xen.org/wiki/Xen_ARM_with_Virtualization_Extensions#Cross_Compiling

Yeah that section covers it. I came across the toolstack page first and didn't check the third link
down in google :)

https://www.google.co.uk/search?q=xen+cross+compilation

Maybe there should be comment in the toolstack page linking back to the simpler hypervisor only steps :)

> 
> or do you mean something more?
> 
> Ian.
>