xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>,
	jbeulich@suse.com, xen-devel@lists.xen.org
Cc: Liu Jinsong <jinsong.liu@alibaba-inc.com>,
	812166@bugs.debian.org, Christoph Egger <chegger@amazon.de>
Subject: Re: [PATCH] x86/mce: fix misleading indentation in init_nonfatal_mce_checker().
Date: Fri, 22 Jan 2016 14:47:51 +0000	[thread overview]
Message-ID: <56A24117.5060305@citrix.com> (raw)
In-Reply-To: <1453473516-22866-1-git-send-email-ian.campbell@citrix.com>

On 22/01/16 14:38, Ian Campbell wrote:
> Debian bug 812166[0] reported this build failure due to
> Wmisleading-indentation with gcc-6:
>
> non-fatal.c: In function 'init_nonfatal_mce_checker':
> non-fatal.c:103:2: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation]
>   switch (c->x86_vendor) {
>   ^~~~~~
>
> non-fatal.c:97:5: note: ...this 'if' clause, but it is not
>      if ( __get_cpu_var(poll_bankmask) == NULL )
>      ^~
>
> I was unable to reproduce (xen builds cleanly for me with "6.0.0 20160117
> (experimental) [trunk revision 232481]") but looking at the code the issue
> above is clearly real.
>
> Correctly reindent the if statement.
>
> This file uses Linux coding style (infact the use of Xen style for
> this line is the root cause of the wanring) so use tabs and while
> there remove the whitespace inside the if as Linux does.
>
> [0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=812166
>
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Cc: Christoph Egger <chegger@amazon.de>
> Cc: Liu Jinsong <jinsong.liu@alibaba-inc.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

  reply	other threads:[~2016-01-22 14:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-22 14:38 [PATCH] x86/mce: fix misleading indentation in init_nonfatal_mce_checker() Ian Campbell
2016-01-22 14:47 ` Andrew Cooper [this message]
2016-01-22 15:12   ` Egger, Christoph

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A24117.5060305@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=812166@bugs.debian.org \
    --cc=chegger@amazon.de \
    --cc=ian.campbell@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=jinsong.liu@alibaba-inc.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).