From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Egger, Christoph" <chegger@amazon.de>
Subject: Re: [PATCH] x86/mce: fix misleading indentation in
 init_nonfatal_mce_checker().
Date: Fri, 22 Jan 2016 16:12:12 +0100
Message-ID: <56A246CC.7040800@amazon.de>
References: <1453473516-22866-1-git-send-email-ian.campbell@citrix.com>
	<56A24117.5060305@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <56A24117.5060305@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, jbeulich@suse.com, xen-devel@lists.xen.org
Cc: Liu Jinsong <jinsong.liu@alibaba-inc.com>, 812166@bugs.debian.org
List-Id: xen-devel@lists.xenproject.org

On 22/01/16 15:47, Andrew Cooper wrote:
> On 22/01/16 14:38, Ian Campbell wrote:
>> Debian bug 812166[0] reported this build failure due to
>> Wmisleading-indentation with gcc-6:
>>
>> non-fatal.c: In function 'init_nonfatal_mce_checker':
>> non-fatal.c:103:2: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation]
>>   switch (c->x86_vendor) {
>>   ^~~~~~
>>
>> non-fatal.c:97:5: note: ...this 'if' clause, but it is not
>>      if ( __get_cpu_var(poll_bankmask) == NULL )
>>      ^~
>>
>> I was unable to reproduce (xen builds cleanly for me with "6.0.0 20160117
>> (experimental) [trunk revision 232481]") but looking at the code the issue
>> above is clearly real.
>>
>> Correctly reindent the if statement.
>>
>> This file uses Linux coding style (infact the use of Xen style for
>> this line is the root cause of the wanring) so use tabs and while
>> there remove the whitespace inside the if as Linux does.
>>
>> [0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=812166
>>
>> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
>> Cc: Christoph Egger <chegger@amazon.de>
>> Cc: Liu Jinsong <jinsong.liu@alibaba-inc.com>
> 
> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> 

Acked-by: Christoph Egger <chegger@amazon.de>

Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B