From: Joao Martins <joao.m.martins@oracle.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Keir Fraser <keir@xen.org>, Jan Beulich <jbeulich@suse.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH RFC 3/6] x86/time: streamline platform time init on plt_init()
Date: Tue, 26 Jan 2016 10:31:39 +0000 [thread overview]
Message-ID: <56A74B0B.7030101@oracle.com> (raw)
In-Reply-To: <20160125202641.GZ14977@char.us.oracle.com>
On 01/25/2016 08:26 PM, Konrad Rzeszutek Wilk wrote:
>> + if ( clocksource_is_tsc )
>> + {
>> + plt_init();
>> + }
>> + else
>> + {
>> + plt_overflow_period = scale_delta(
>> + 1ull << (pts->counter_bits-1), &plt_scale);
>> + init_timer(&plt_overflow_timer, plt_overflow, NULL, 0);
>> + plt_overflow(NULL);
>> +
>> + printk("Platform timer overflow period is %lu secs\n",
>> + plt_overflow_period/1000000000);
>
> s/1000000000/SECONDS(1) ?
>
Yeah, looks much better that way.
>> + }
>>
>> platform_timer_stamp = plt_stamp64;
>> stime_platform_stamp = NOW();
>> --
>> 2.1.4
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-01-26 10:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-28 16:59 [PATCH RFC 0/6] x86/time: PVCLOCK_TSC_STABLE_BIT support Joao Martins
2015-12-28 16:59 ` [PATCH RFC 1/6] public/xen.h: add flags field to vcpu_time_info Joao Martins
2016-01-25 20:11 ` Konrad Rzeszutek Wilk
2016-01-26 10:31 ` Joao Martins
2015-12-28 16:59 ` [PATCH RFC 2/6] x86/time: implement tsc as clocksource Joao Martins
2015-12-29 15:11 ` Andrew Cooper
2015-12-29 17:37 ` Joao Martins
2015-12-28 16:59 ` [PATCH RFC 3/6] x86/time: streamline platform time init on plt_init() Joao Martins
2016-01-25 20:26 ` Konrad Rzeszutek Wilk
2016-01-26 10:31 ` Joao Martins [this message]
2015-12-28 16:59 ` [PATCH RFC 4/6] x86/time: refactor read_platform_stime() Joao Martins
2015-12-28 16:59 ` [PATCH RFC 5/6] x86/time: implement PVCLOCK_TSC_STABLE_BIT Joao Martins
2015-12-28 16:59 ` [PATCH RFC 6/6] x86/time: convert counter to tsc for non-tsc clocksource Joao Martins
2015-12-29 14:58 ` [PATCH RFC 0/6] x86/time: PVCLOCK_TSC_STABLE_BIT support Andrew Cooper
2015-12-29 17:37 ` Joao Martins
2016-02-22 21:14 ` Joao Martins
2016-02-23 8:09 ` Jan Beulich
2016-02-23 12:13 ` Joao Martins
2015-12-30 3:47 ` Haozhong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A74B0B.7030101@oracle.com \
--to=joao.m.martins@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).