From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v5] x86/p2m: use large pages for MMIO
	mappings
Date: Wed, 27 Jan 2016 10:28:36 +0000
Message-ID: <56A89BD4.6030008@citrix.com>
References: <56A25C0602000078000CA367@prv-mh.provo.novell.com>
	<1453724207.4320.137.camel@citrix.com>
	<56A6371802000078000CAA6B@prv-mh.provo.novell.com>
	<1453730752.4320.164.camel@citrix.com>
	<56A63C4002000078000CAAA7@prv-mh.provo.novell.com>
	<1453731704.4320.173.camel@citrix.com>
	<56A658FE02000078000CAC3D@prv-mh.provo.novell.com>
	<AADFC41AFE54684AB9EE6CBC0274A5D15F78ED47@SHSMSX101.ccr.corp.intel.com>
	<56A8A88F02000078000CB780@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=82734b35b=Andrew.Cooper3@citrix.com>)
	id 1aONLK-0003Lo-Mr
	for xen-devel@lists.xenproject.org; Wed, 27 Jan 2016 10:28:54 +0000
In-Reply-To: <56A8A88F02000078000CB780@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Kevin Tian <kevin.tian@intel.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Tim Deegan <tim@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Jun Nakajima <jun.nakajima@intel.com>, xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 27/01/16 10:22, Jan Beulich wrote:
>>>> On 26.01.16 at 23:35, <kevin.tian@intel.com> wrote:
>>>  From: Jan Beulich [mailto:JBeulich@suse.com]
>>> Sent: Tuesday, January 26, 2016 12:19 AM
>>>
>>> When mapping large BARs (e.g. the frame buffer of a graphics card) the
>>> overhead of establishing such mappings using only 4k pages has,
>>> particularly after the XSA-125 fix, become unacceptable. Alter the
>>> XEN_DOMCTL_memory_mapping semantics once again, so that there's no
>>> longer a fixed amount of guest frames that represents the upper limit
>>> of what a single invocation can map. Instead bound execution time by
>>> limiting the number of iterations (regardless of page size).
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> Acked-by: Kevin Tian <kevin.tian@intel.com> for VMX part.
>>
>> Curious. When you say "become unacceptable", how bad is it? mostly
>> impact the boot time?
> Yes, guest boot time. I don't have a reference to the original report
> at hand, but that was what someone (Konrad?) had reported. I've
> never seen the issue myself, largely because I've never made any
> attempt at GPU pass-through.

>>From XenServer testing, with a 1GB GPU BAR, XSA-125 caused and
additional 70s of guest boot time.

Naturally. we had to work around this.  Partly upping the repeat limit,
and deferring VT-d flushes.

~Andrew