From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Lars Kurth <lars.kurth@citrix.com>,
Changlong Xie <xiecl.fnst@cn.fujitsu.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <ian.campbell@citrix.com>,
Wen Congyang <wency@cn.fujitsu.com>,
Gui Jianfeng <guijianfeng@cn.fujitsu.com>,
Jiang Yunhong <yunhong.jiang@intel.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen devel <xen-devel@lists.xen.org>,
Dong Eddie <eddie.dong@intel.com>,
Shriram Rajagopalan <rshriram@cs.ubc.ca>,
Yang Hongyang <hongyang.yang@easystack.cn>
Subject: Re: [PATCH v9 02/25] docs/libxl: Introduce COLO_CONTEXT to support migration v2 colo streams
Date: Wed, 27 Jan 2016 15:15:47 +0000 [thread overview]
Message-ID: <56A8DF23.6060007@citrix.com> (raw)
In-Reply-To: <20160127151157.GE552@char.us.oracle.com>
On 27/01/16 15:11, Konrad Rzeszutek Wilk wrote:
> On Wed, Jan 27, 2016 at 11:00:24AM +0000, Andrew Cooper wrote:
>> On 27/01/16 06:47, Wen Congyang wrote:
>>> On 01/27/2016 04:40 AM, Konrad Rzeszutek Wilk wrote:
>>>> On Wed, Dec 30, 2015 at 10:37:32AM +0800, Wen Congyang wrote:
>>>>> It is the negotiation record for COLO.
>>>>> Primary->Secondary:
>>>>> control_id 0x00000000: Secondary VM is out of sync, start a new checkpoint
>>>>> Secondary->Primary:
>>>>> 0x00000001: Secondary VM is suspended
>>>>> 0x00000002: Secondary VM is ready
>>>>> 0x00000003: Secondary VM is resumed
>>>>>
>>>>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>>>>> Signed-off-by: Yang Hongyang <hongyang.yang@easystack.cn>
>>>>> ---
>>>>> docs/specs/libxl-migration-stream.pandoc | 25 +++++++++++++++++++++++--
>>>>> tools/libxl/libxl_sr_stream_format.h | 11 +++++++++++
>>>>> tools/python/xen/migration/libxl.py | 9 +++++++++
>>>>> 3 files changed, 43 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/docs/specs/libxl-migration-stream.pandoc b/docs/specs/libxl-migration-stream.pandoc
>>>>> index 2c97d86..5166d66 100644
>>>>> --- a/docs/specs/libxl-migration-stream.pandoc
>>>>> +++ b/docs/specs/libxl-migration-stream.pandoc
>>>>> @@ -1,6 +1,6 @@
>>>>> % LibXenLight Domain Image Format
>>>>> % Andrew Cooper <<andrew.cooper3@citrix.com>>
>>>>> -% Revision 1
>>>>> +% Revision 2
>>>>>
>>>>> Introduction
>>>>> ============
>>>>> @@ -119,7 +119,9 @@ type 0x00000000: END
>>>>>
>>>>> 0x00000004: CHECKPOINT_END
>>>>>
>>>>> - 0x00000005 - 0x7FFFFFFF: Reserved for future _mandatory_
>>>>> + 0x00000005: CHECKPOINT_STATE
>>>>> +
>>>>> + 0x00000006 - 0x7FFFFFFF: Reserved for future _mandatory_
>>>> This is in the 'mandatory' records. Should it be part of optional records?
>>>>
>>>> Would this checkpoint state always present on non-COLO guest migration?
>>> No. Will be fixed in the next version
>> It is correct that CHECKPOINT_STATE is a mandatory record.
>>
>> Optional records which are free for the receiving end to ignore if they
>> are not understood.
> What you are saying is that the receving end has to expect this (CHECKPOINT_STATE)
> even there is nothing in them - as the size of them is zero (becuase there are
> no dirty PFNs to send).
The sole difference between a mandatory record an an option record is
the receivers behaviour.
Mandatory records may not be ignored, and constitutes a hard error.
Optional records may be ignored, without error, if they are not understood.
~Andrew
next prev parent reply other threads:[~2016-01-27 15:15 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-30 2:37 [PATCH v9 00/25] COarse-grain LOck-stepping Virtual Machines for Non-stop Service Wen Congyang
2015-12-30 2:37 ` [PATCH v9 01/25] docs: add colo readme Wen Congyang
2015-12-30 2:37 ` [PATCH v9 02/25] docs/libxl: Introduce COLO_CONTEXT to support migration v2 colo streams Wen Congyang
2016-01-26 20:40 ` Konrad Rzeszutek Wilk
2016-01-27 6:47 ` Wen Congyang
2016-01-27 11:00 ` Andrew Cooper
2016-01-27 15:11 ` Konrad Rzeszutek Wilk
2016-01-27 15:15 ` Andrew Cooper [this message]
2016-01-27 15:28 ` Konrad Rzeszutek Wilk
2016-01-27 15:30 ` Andrew Cooper
2016-01-27 16:01 ` Ian Jackson
2015-12-30 2:37 ` [PATCH v9 03/25] libxc/migration: Specification update for DIRTY_PFN_LIST records Wen Congyang
2016-01-26 20:44 ` Konrad Rzeszutek Wilk
2016-01-27 6:47 ` Wen Congyang
2016-01-27 7:12 ` Wen Congyang
2016-01-27 10:00 ` Ian Campbell
2016-01-27 11:01 ` Andrew Cooper
2015-12-30 2:37 ` [PATCH v9 04/25] libxc/migration: export read_record for common use Wen Congyang
2016-01-26 20:45 ` Konrad Rzeszutek Wilk
2016-01-27 0:57 ` Wen Congyang
2015-12-30 2:37 ` [PATCH v9 05/25] tools/libxl: add back channel support to write stream Wen Congyang
2015-12-30 2:37 ` [PATCH v9 06/25] tools/libxl: write checkpoint_state records into the stream Wen Congyang
2015-12-30 2:37 ` [PATCH v9 07/25] tools/libxl: add back channel support to read stream Wen Congyang
2015-12-30 2:37 ` [PATCH v9 08/25] tools/libxl: handle checkpoint_state records in a libxl migration v2 " Wen Congyang
2015-12-30 2:37 ` [PATCH v9 09/25] tools/libx{l, c}: introduce should_checkpoint callback Wen Congyang
2016-01-26 20:50 ` Konrad Rzeszutek Wilk
2016-01-26 21:09 ` Konrad Rzeszutek Wilk
2016-01-27 1:03 ` Wen Congyang
2016-01-27 1:18 ` Wen Congyang
2015-12-30 2:37 ` [PATCH v9 10/25] tools/libx{l, c}: add postcopy/suspend callback to restore side Wen Congyang
2015-12-30 2:37 ` [PATCH v9 11/25] secondary vm suspend/resume/checkpoint code Wen Congyang
2015-12-30 2:37 ` [PATCH v9 12/25] primary " Wen Congyang
2015-12-30 2:37 ` [PATCH v9 13/25] libxc/restore: support COLO restore Wen Congyang
2015-12-30 2:37 ` [PATCH v9 14/25] libxc/restore: send dirty pfn list to primary when checkpoint under colo Wen Congyang
2015-12-30 2:37 ` [PATCH v9 15/25] send store gfn and console gfn to xl before resuming secondary vm Wen Congyang
2015-12-30 2:37 ` [PATCH v9 16/25] libxc/save: support COLO save Wen Congyang
2015-12-30 2:37 ` [PATCH v9 17/25] implement the cmdline for COLO Wen Congyang
2015-12-30 2:37 ` [PATCH v9 18/25] Support colo mode for qemu disk Wen Congyang
2015-12-30 2:37 ` [PATCH v9 19/25] COLO: use qemu block replication Wen Congyang
2015-12-30 2:37 ` [PATCH v9 20/25] COLO proxy: implement setup/teardown of COLO proxy module Wen Congyang
2015-12-30 2:37 ` [PATCH v9 21/25] COLO proxy: preresume, postresume and checkpoint Wen Congyang
2015-12-30 2:37 ` [PATCH v9 22/25] COLO nic: implement COLO nic subkind Wen Congyang
2015-12-30 2:37 ` [PATCH v9 23/25] setup and control colo proxy on primary side Wen Congyang
2015-12-30 2:37 ` [PATCH v9 24/25] setup and control colo proxy on secondary side Wen Congyang
2015-12-30 2:37 ` [PATCH v9 25/25] cmdline switches and config vars to control colo-proxy Wen Congyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A8DF23.6060007@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=eddie.dong@intel.com \
--cc=guijianfeng@cn.fujitsu.com \
--cc=hongyang.yang@easystack.cn \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=lars.kurth@citrix.com \
--cc=rshriram@cs.ubc.ca \
--cc=wei.liu2@citrix.com \
--cc=wency@cn.fujitsu.com \
--cc=xen-devel@lists.xen.org \
--cc=xiecl.fnst@cn.fujitsu.com \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).