From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 1/4] x86/xstate: fix xcomp_bv initialization Date: Fri, 29 Jan 2016 15:07:16 +0000 Message-ID: <56AB8024.9040607@citrix.com> References: <56AB4B6102000078000CC51B@prv-mh.provo.novell.com> <56AB4C7902000078000CC53B@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aPAds-0002rq-Gd for xen-devel@lists.xenproject.org; Fri, 29 Jan 2016 15:07:20 +0000 In-Reply-To: <56AB4C7902000078000CC53B@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Keir Fraser , Harmandeep Kaur , Shuai Ruan List-Id: xen-devel@lists.xenproject.org On 29/01/16 10:26, Jan Beulich wrote: > We must not clear the compaction bit when using XSAVES/XRSTORS. And > we need to guarantee that xcomp_bv never has any bits clear which > are set in xstate_bv (which requires partly undoing commit 83ae0bb226 > ["x86/xsave: simplify xcomp_bv initialization"]). Split initialization > of xcomp_bv from the other FPU/SSE/AVX related state setup in > arch_set_info_guest() and hvm_load_cpu_ctxt(). > > Reported-by: Harmandeep Kaur > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper