From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 2/4] x86: adjust xsave structure attributes Date: Fri, 29 Jan 2016 15:07:37 +0000 Message-ID: <56AB8039.20206@citrix.com> References: <56AB4B6102000078000CC51B@prv-mh.provo.novell.com> <56AB4CAA02000078000CC53F@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aPAeD-0002t4-W4 for xen-devel@lists.xenproject.org; Fri, 29 Jan 2016 15:07:42 +0000 In-Reply-To: <56AB4CAA02000078000CC53F@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Keir Fraser , Harmandeep Kaur , Shuai Ruan List-Id: xen-devel@lists.xenproject.org On 29/01/16 10:27, Jan Beulich wrote: > The packed attribute was pointlessly used here - there are no > misaligned fields, and hence even if the attribute took effect, it > would at best lead to the compiler generating worse code. > > At the same time specify the required alignment of the fpu_sse sub- > structure, such that the various typeof() uses on that field obtain > pointers to properly aligned memory (knowledge which a compiler may > want to make use of). > > Also add suitable build-time checks. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper