From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Corneliu ZUZU <czuzu@bitdefender.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] x86/hvm: Fix use-after-free introduced by c/s 428607a
Date: Tue, 2 Feb 2016 10:48:32 +0000 [thread overview]
Message-ID: <56B08980.8060607@citrix.com> (raw)
In-Reply-To: <56B0964502000078000CD620@prv-mh.provo.novell.com>
On 02/02/16 10:43, Jan Beulich wrote:
>>>> On 01.02.16 at 18:56, <andrew.cooper3@citrix.com> wrote:
>> For safety, NULL out the pointers after freeing them, in an attempt to make
>> mistakes more obvious in the future.
> Except that NULLing isn't really adding that much safety, and we'd
> be better off poisoning such pointers. Nevertheless ...
NULLing the pointers would cause things like rtc_deinit() to always blow
up when it followed the NULL pointer.
IMO, we should unconditionally always NULL pointers when freeing a
pointer which isn't in local scope. It would make issues such as these
completely obvious.
~Andrew
next prev parent reply other threads:[~2016-02-02 10:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-01 17:56 [PATCH] x86/hvm: Fix use-after-free introduced by c/s 428607a Andrew Cooper
2016-02-02 8:00 ` Corneliu ZUZU
2016-02-02 10:04 ` Andrew Cooper
2016-02-02 10:43 ` Jan Beulich
2016-02-02 10:48 ` Andrew Cooper [this message]
2016-02-02 10:52 ` Jan Beulich
2016-02-02 10:57 ` Andrew Cooper
2016-02-02 11:39 ` Corneliu ZUZU
2016-02-02 11:44 ` Jan Beulich
2016-02-02 12:05 ` Andrew Cooper
2016-02-02 12:51 ` Corneliu ZUZU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B08980.8060607@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=czuzu@bitdefender.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).