* [PATCH] xen/arm64: Make sure we get all debug output @ 2016-02-04 16:49 Dirk Behme 2016-02-04 17:00 ` Ian Campbell 0 siblings, 1 reply; 8+ messages in thread From: Dirk Behme @ 2016-02-04 16:49 UTC (permalink / raw) To: xen-devel, ian.campbell; +Cc: Dirk Behme From: Dirk Behme <dirk.behme@de.bosch.com> Starting in the wrong ELx mode I get the following debug output: ... - Current EL 00000004 - - Xen must be entered in NS EL2 mode - - Boot failed - The output of "Please update the bootloader" is missing here. Make sure this is output, too. With this, we get ... - Current EL 00000004 - - Xen must be entered in NS EL2 mode - - Please update the bootloader - - Boot failed - as intended. Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com> --- xen/arch/arm/arm64/head.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 9ed9a93..19fa2bb 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -309,8 +309,8 @@ common_start: b.eq el2 /* Yes */ /* OK, we're boned. */ - PRINT("- Xen must be entered in NS EL2 mode -\r\n" \ - "- Please update the bootloader -\r\n") + PRINT("- Xen must be entered in NS EL2 mode -\r\n") + PRINT("- Please update the bootloader -\r\n") b fail el2: PRINT("- Xen starting at EL2 -\r\n") -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] xen/arm64: Make sure we get all debug output 2016-02-04 16:49 [PATCH] xen/arm64: Make sure we get all debug output Dirk Behme @ 2016-02-04 17:00 ` Ian Campbell 2016-02-04 17:07 ` Dirk Behme 0 siblings, 1 reply; 8+ messages in thread From: Ian Campbell @ 2016-02-04 17:00 UTC (permalink / raw) To: Dirk Behme, xen-devel; +Cc: Dirk Behme On Thu, 2016-02-04 at 17:49 +0100, Dirk Behme wrote: > From: Dirk Behme <dirk.behme@de.bosch.com> > > Starting in the wrong ELx mode I get the following debug output: > > ... > - Current EL 00000004 - > - Xen must be entered in NS EL2 mode - > - Boot failed - > > The output of "Please update the bootloader" is missing here. > > Make sure this is output, too. With this, we get > > ... > - Current EL 00000004 - > - Xen must be entered in NS EL2 mode - > - Please update the bootloader - > - Boot failed - > > as intended. Ah, this is because gas does not concatenate strings in the same way as C, i.e. in C: "A" "B" "C" becomes 'A', 'B', 'C', '\0' while in gas it becomes 'A', '\0', 'B', '\0', 'C', '\0' I'd like to modify the "...is missing here" above to go a bit further: ...is missing here, because string concatenation in gas, unlike in C, keeps the \0 between each individual string. Would that be OK with you? (I can do it on commit if you are happy with it) > > Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com> > --- > xen/arch/arm/arm64/head.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S > index 9ed9a93..19fa2bb 100644 > --- a/xen/arch/arm/arm64/head.S > +++ b/xen/arch/arm/arm64/head.S > @@ -309,8 +309,8 @@ common_start: > b.eq el2 /* Yes */ > > /* OK, we're boned. */ > - PRINT("- Xen must be entered in NS EL2 mode -\r\n" \ > - "- Please update the bootloader -\r\n") > + PRINT("- Xen must be entered in NS EL2 mode -\r\n") > + PRINT("- Please update the bootloader -\r\n") > b fail > > el2: PRINT("- Xen starting at EL2 -\r\n") _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xen/arm64: Make sure we get all debug output 2016-02-04 17:00 ` Ian Campbell @ 2016-02-04 17:07 ` Dirk Behme 2016-02-17 16:49 ` Dirk Behme 0 siblings, 1 reply; 8+ messages in thread From: Dirk Behme @ 2016-02-04 17:07 UTC (permalink / raw) To: Ian Campbell, xen-devel; +Cc: Dirk Behme On 04.02.2016 18:00, Ian Campbell wrote: > On Thu, 2016-02-04 at 17:49 +0100, Dirk Behme wrote: >> From: Dirk Behme <dirk.behme@de.bosch.com> >> >> Starting in the wrong ELx mode I get the following debug output: >> >> ... >> - Current EL 00000004 - >> - Xen must be entered in NS EL2 mode - >> - Boot failed - >> >> The output of "Please update the bootloader" is missing here. >> >> Make sure this is output, too. With this, we get >> >> ... >> - Current EL 00000004 - >> - Xen must be entered in NS EL2 mode - >> - Please update the bootloader - >> - Boot failed - >> >> as intended. > > Ah, this is because gas does not concatenate strings in the same way as C, > i.e. in C: > "A" "B" "C" > > becomes 'A', 'B', 'C', '\0' > > while in gas it becomes 'A', '\0', 'B', '\0', 'C', '\0' > > I'd like to modify the "...is missing here" above to go a bit further: > > ...is missing here, because string concatenation in gas, unlike in C, > keeps the \0 between each individual string. > > Would that be OK with you? (I can do it on commit if you are happy with it) Sure, fine with me :) Many thanks! Dirk >> >> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com> >> --- >> xen/arch/arm/arm64/head.S | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S >> index 9ed9a93..19fa2bb 100644 >> --- a/xen/arch/arm/arm64/head.S >> +++ b/xen/arch/arm/arm64/head.S >> @@ -309,8 +309,8 @@ common_start: >> b.eq el2 /* Yes */ >> >> /* OK, we're boned. */ >> - PRINT("- Xen must be entered in NS EL2 mode -\r\n" \ >> - "- Please update the bootloader -\r\n") >> + PRINT("- Xen must be entered in NS EL2 mode -\r\n") >> + PRINT("- Please update the bootloader -\r\n") >> b fail >> >> el2: PRINT("- Xen starting at EL2 -\r\n") > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xen/arm64: Make sure we get all debug output 2016-02-04 17:07 ` Dirk Behme @ 2016-02-17 16:49 ` Dirk Behme 2016-02-18 10:15 ` Ian Campbell 0 siblings, 1 reply; 8+ messages in thread From: Dirk Behme @ 2016-02-17 16:49 UTC (permalink / raw) To: Ian Campbell, xen-devel; +Cc: Dirk Behme, Dirk Behme On 04.02.2016 18:07, Dirk Behme wrote: > On 04.02.2016 18:00, Ian Campbell wrote: >> On Thu, 2016-02-04 at 17:49 +0100, Dirk Behme wrote: >>> From: Dirk Behme <dirk.behme@de.bosch.com> >>> >>> Starting in the wrong ELx mode I get the following debug output: >>> >>> ... >>> - Current EL 00000004 - >>> - Xen must be entered in NS EL2 mode - >>> - Boot failed - >>> >>> The output of "Please update the bootloader" is missing here. >>> >>> Make sure this is output, too. With this, we get >>> >>> ... >>> - Current EL 00000004 - >>> - Xen must be entered in NS EL2 mode - >>> - Please update the bootloader - >>> - Boot failed - >>> >>> as intended. >> >> Ah, this is because gas does not concatenate strings in the same way >> as C, >> i.e. in C: >> "A" "B" "C" >> >> becomes 'A', 'B', 'C', '\0' >> >> while in gas it becomes 'A', '\0', 'B', '\0', 'C', '\0' >> >> I'd like to modify the "...is missing here" above to go a bit further: >> >> ...is missing here, because string concatenation in gas, unlike >> in C, >> keeps the \0 between each individual string. >> >> Would that be OK with you? (I can do it on commit if you are happy >> with it) > > > Sure, fine with me :) Could this be applied, then? Best regards Dirk >>> >>> Signed-off-by: Dirk Behme <dirk.behme@de.bosch.com> >>> --- >>> xen/arch/arm/arm64/head.S | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S >>> index 9ed9a93..19fa2bb 100644 >>> --- a/xen/arch/arm/arm64/head.S >>> +++ b/xen/arch/arm/arm64/head.S >>> @@ -309,8 +309,8 @@ common_start: >>> b.eq el2 /* Yes */ >>> >>> /* OK, we're boned. */ >>> - PRINT("- Xen must be entered in NS EL2 mode -\r\n" \ >>> - "- Please update the bootloader -\r\n") >>> + PRINT("- Xen must be entered in NS EL2 mode -\r\n") >>> + PRINT("- Please update the bootloader -\r\n") >>> b fail >>> >>> el2: PRINT("- Xen starting at EL2 -\r\n") >> > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xen/arm64: Make sure we get all debug output 2016-02-17 16:49 ` Dirk Behme @ 2016-02-18 10:15 ` Ian Campbell 2016-02-18 10:21 ` Jan Beulich 0 siblings, 1 reply; 8+ messages in thread From: Ian Campbell @ 2016-02-18 10:15 UTC (permalink / raw) To: Dirk Behme, xen-devel Cc: Dirk Behme, Ian Jackson, Jan Beulich, Dirk Behme, Stefano Stabellini On Wed, 2016-02-17 at 17:49 +0100, Dirk Behme wrote: > Could this be applied, then? Yes, sorry, this fell through the cracks somehow. I've applied it to #staging now (from where automated testing will push it into #master). I also added the same change to arm32/head.S and noted that I'd done so in the commit log, I figured it would be better to avoid another RTT and another chance to slip through the cracks to ask in advance, I hope that's ok. I think this would be worth backporting to 4.6 and earlier (as far back as it applies). Jan or Ian -- would one of you mind doing so when the time comes please? (FYI I have no other pending backports) Ian. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xen/arm64: Make sure we get all debug output 2016-02-18 10:15 ` Ian Campbell @ 2016-02-18 10:21 ` Jan Beulich 2016-02-19 17:13 ` Ian Jackson 0 siblings, 1 reply; 8+ messages in thread From: Jan Beulich @ 2016-02-18 10:21 UTC (permalink / raw) To: Ian Campbell Cc: Dirk Behme, Stefano Stabellini, Dirk Behme, Ian Jackson, Dirk Behme, xen-devel >>> On 18.02.16 at 11:15, <ian.campbell@citrix.com> wrote: > On Wed, 2016-02-17 at 17:49 +0100, Dirk Behme wrote: >> Could this be applied, then? > > Yes, sorry, this fell through the cracks somehow. I've applied it to > #staging now (from where automated testing will push it into #master). > > I also added the same change to arm32/head.S and noted that I'd done so in > the commit log, I figured it would be better to avoid another RTT and > another chance to slip through the cracks to ask in advance, I hope that's > ok. > > I think this would be worth backporting to 4.6 and earlier (as far back as > it applies). Jan or Ian -- would one of you mind doing so when the time > comes please? (FYI I have no other pending backports) Sure. Jan ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xen/arm64: Make sure we get all debug output 2016-02-18 10:21 ` Jan Beulich @ 2016-02-19 17:13 ` Ian Jackson 2016-02-19 17:16 ` Jan Beulich 0 siblings, 1 reply; 8+ messages in thread From: Ian Jackson @ 2016-02-19 17:13 UTC (permalink / raw) To: Jan Beulich Cc: Dirk Behme, Ian Campbell, Stefano Stabellini, Dirk Behme, Dirk Behme, xen-devel Jan Beulich writes ("Re: [PATCH] xen/arm64: Make sure we get all debug output"): > On 18.02.16 at 11:15, <ian.campbell@citrix.com> wrote: > > I think this would be worth backporting to 4.6 and earlier (as far back as > > it applies). Jan or Ian -- would one of you mind doing so when the time > > comes please? (FYI I have no other pending backports) > > Sure. I have added this to my list too (but won't mind if Jan gets to it first). Ian. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] xen/arm64: Make sure we get all debug output 2016-02-19 17:13 ` Ian Jackson @ 2016-02-19 17:16 ` Jan Beulich 0 siblings, 0 replies; 8+ messages in thread From: Jan Beulich @ 2016-02-19 17:16 UTC (permalink / raw) To: Ian Jackson Cc: Dirk Behme, Ian Campbell, Stefano Stabellini, DirkBehme, Dirk Behme, xen-devel >>> On 19.02.16 at 18:13, <Ian.Jackson@eu.citrix.com> wrote: > Jan Beulich writes ("Re: [PATCH] xen/arm64: Make sure we get all debug > output"): >> On 18.02.16 at 11:15, <ian.campbell@citrix.com> wrote: >> > I think this would be worth backporting to 4.6 and earlier (as far back as >> > it applies). Jan or Ian -- would one of you mind doing so when the time >> > comes please? (FYI I have no other pending backports) >> >> Sure. > > I have added this to my list too (but won't mind if Jan gets to it > first). It's already done (I had pushed it together with the XSA-154 fixup). Jan ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-02-19 17:16 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-02-04 16:49 [PATCH] xen/arm64: Make sure we get all debug output Dirk Behme 2016-02-04 17:00 ` Ian Campbell 2016-02-04 17:07 ` Dirk Behme 2016-02-17 16:49 ` Dirk Behme 2016-02-18 10:15 ` Ian Campbell 2016-02-18 10:21 ` Jan Beulich 2016-02-19 17:13 ` Ian Jackson 2016-02-19 17:16 ` Jan Beulich
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).