* [PATCH] x86emul: drop redundant #GP checks
@ 2016-02-05 7:33 Jan Beulich
2016-02-05 14:16 ` Andrew Cooper
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2016-02-05 7:33 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, Keir Fraser
[-- Attachment #1: Type: text/plain, Size: 1162 bytes --]
in_protmode() implies !in_realmode(), so we don't need to check both.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/x86_emulate/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate/x86_emulate.c
@@ -3972,7 +3972,6 @@ x86_emulate(
uint64_t msr_content;
struct segment_register cs, ss;
- generate_exception_if(in_realmode(ctxt, ops), EXC_UD, -1);
generate_exception_if(!in_protmode(ctxt, ops), EXC_UD, -1);
/* Inject #UD if syscall/sysret are disabled. */
@@ -4218,7 +4217,6 @@ x86_emulate(
int lm;
generate_exception_if(mode_ring0(), EXC_GP, 0);
- generate_exception_if(in_realmode(ctxt, ops), EXC_GP, 0);
generate_exception_if(!in_protmode(ctxt, ops), EXC_GP, 0);
fail_if(ops->read_msr == NULL);
@@ -4267,7 +4265,6 @@ x86_emulate(
bool_t user64 = !!(rex_prefix & REX_W);
generate_exception_if(!mode_ring0(), EXC_GP, 0);
- generate_exception_if(in_realmode(ctxt, ops), EXC_GP, 0);
generate_exception_if(!in_protmode(ctxt, ops), EXC_GP, 0);
fail_if(ops->read_msr == NULL);
[-- Attachment #2: x86emul-redundant-checks.patch --]
[-- Type: text/plain, Size: 1194 bytes --]
x86emul: drop redundant #GP checks
in_protmode() implies !in_realmode(), so we don't need to check both.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/x86_emulate/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate/x86_emulate.c
@@ -3972,7 +3972,6 @@ x86_emulate(
uint64_t msr_content;
struct segment_register cs, ss;
- generate_exception_if(in_realmode(ctxt, ops), EXC_UD, -1);
generate_exception_if(!in_protmode(ctxt, ops), EXC_UD, -1);
/* Inject #UD if syscall/sysret are disabled. */
@@ -4218,7 +4217,6 @@ x86_emulate(
int lm;
generate_exception_if(mode_ring0(), EXC_GP, 0);
- generate_exception_if(in_realmode(ctxt, ops), EXC_GP, 0);
generate_exception_if(!in_protmode(ctxt, ops), EXC_GP, 0);
fail_if(ops->read_msr == NULL);
@@ -4267,7 +4265,6 @@ x86_emulate(
bool_t user64 = !!(rex_prefix & REX_W);
generate_exception_if(!mode_ring0(), EXC_GP, 0);
- generate_exception_if(in_realmode(ctxt, ops), EXC_GP, 0);
generate_exception_if(!in_protmode(ctxt, ops), EXC_GP, 0);
fail_if(ops->read_msr == NULL);
[-- Attachment #3: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-05 14:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-05 7:33 [PATCH] x86emul: drop redundant #GP checks Jan Beulich
2016-02-05 14:16 ` Andrew Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).