From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@citrix.com>
Subject: Re: [PATCH] xl: use bool type for flags instead of int
Date: Mon, 8 Feb 2016 10:21:07 +0000
Message-ID: <56B86C13.1060006@citrix.com>
References: <20160206020052.6436.89943.stgit@Solace.station>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=839aabcfe=George.Dunlap@citrix.com>)
	id 1aSiwS-0007tP-IW
	for xen-devel@lists.xenproject.org; Mon, 08 Feb 2016 10:21:12 +0000
In-Reply-To: <20160206020052.6436.89943.stgit@Solace.station>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Dario Faggioli <dario.faggioli@citrix.com>, xen-devel@lists.xenproject.org
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 06/02/16 02:00, Dario Faggioli wrote:
> in schedulers' command handlers.
> 
> No functional change intended.
> 
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>

Acked-by: George Dunlap <george.dunlap@citrix.com>

> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: George Dunlap <george.dunlap@citrix.com>
> ---
>  tools/libxl/xl_cmdimpl.c |   27 +++++++++++++++------------
>  1 file changed, 15 insertions(+), 12 deletions(-)
> 
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 20704d2..d07ccb2 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -6035,9 +6035,11 @@ int main_sched_credit(int argc, char **argv)
>  {
>      const char *dom = NULL;
>      const char *cpupool = NULL;
> -    int weight = 256, cap = 0, opt_w = 0, opt_c = 0;
> -    int opt_s = 0;
> -    int tslice = 0, opt_t = 0, ratelimit = 0, opt_r = 0;
> +    int weight = 256, cap = 0;
> +    int tslice = 0, ratelimit = 0;
> +    bool opt_w = false, opt_c = false;
> +    bool opt_t = false, opt_r = false;
> +    bool opt_s = false;
>      int opt, rc;
>      static struct option opts[] = {
>          {"domain", 1, 0, 'd'},
> @@ -6056,22 +6058,22 @@ int main_sched_credit(int argc, char **argv)
>          break;
>      case 'w':
>          weight = strtol(optarg, NULL, 10);
> -        opt_w = 1;
> +        opt_w = true;
>          break;
>      case 'c':
>          cap = strtol(optarg, NULL, 10);
> -        opt_c = 1;
> +        opt_c = true;
>          break;
>      case 't':
>          tslice = strtol(optarg, NULL, 10);
> -        opt_t = 1;
> +        opt_t = true;
>          break;
>      case 'r':
>          ratelimit = strtol(optarg, NULL, 10);
> -        opt_r = 1;
> +        opt_r = true;
>          break;
>      case 's':
> -        opt_s = 1;
> +        opt_s = true;
>          break;
>      case 'p':
>          cpupool = optarg;
> @@ -6157,7 +6159,8 @@ int main_sched_credit2(int argc, char **argv)
>  {
>      const char *dom = NULL;
>      const char *cpupool = NULL;
> -    int weight = 256, opt_w = 0;
> +    int weight = 256;
> +    bool opt_w = false;
>      int opt, rc;
>      static struct option opts[] = {
>          {"domain", 1, 0, 'd'},
> @@ -6172,7 +6175,7 @@ int main_sched_credit2(int argc, char **argv)
>          break;
>      case 'w':
>          weight = strtol(optarg, NULL, 10);
> -        opt_w = 1;
> +        opt_w = true;
>          break;
>      case 'p':
>          cpupool = optarg;
> @@ -6246,11 +6249,11 @@ int main_sched_rtds(int argc, char **argv)
>          break;
>      case 'p':
>          period = strtol(optarg, NULL, 10);
> -        opt_p = 1;
> +        opt_p = true;
>          break;
>      case 'b':
>          budget = strtol(optarg, NULL, 10);
> -        opt_b = 1;
> +        opt_b = true;
>          break;
>      case 'c':
>          cpupool = optarg;
>