From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH 1/2] xenoprof: fix up ability to disable it
Date: Mon, 8 Feb 2016 11:24:02 -0500
Message-ID: <56B8C122.1060207@oracle.com>
References: <1454947487-8588-1-git-send-email-cardoe@cardoe.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1454947487-8588-1-git-send-email-cardoe@cardoe.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Doug Goldstein <cardoe@cardoe.com>, xen-devel@lists.xen.org
Cc: Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>, Jan Beulich <jbeulich@suse.com>, Jun Nakajima <jun.nakajima@intel.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
List-Id: xen-devel@lists.xenproject.org



On 02/08/2016 11:04 AM, Doug Goldstein wrote:
> Allow Xenoprof to be fully disabled when toggling the option off.
>
> CC: Keir Fraser <keir@xen.org>
> CC: Jan Beulich <jbeulich@suse.com>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> CC: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> CC: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
> CC: Jun Nakajima <jun.nakajima@intel.com>
> CC: Kevin Tian <kevin.tian@intel.com>
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>


> @@ -2666,10 +2669,11 @@ static int vmx_msr_write_intercept(unsigned int msr, uint64_t msr_content)
>               goto gp_fault;
>           break;
>       default:
> -        if ( passive_domain_do_wrmsr(msr, msr_content) )
> +        if ( IS_ENABLED(CONFIG_XENOPROF) &&
> +             passive_domain_do_wrmsr(msr, msr_content) )
>               return X86EMUL_OKAY;
>   
> -        if ( wrmsr_viridian_regs(msr, msr_content) )
> +        if ( wrmsr_viridian_regs(msr, msr_content) )
>               break;

Looks like a stray change.

Other than that,

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

While at it --- I think we should put VPMU code under CONFIG option too, 
especially given its support status. I can do that (unless Doug wants to).

-boris