From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [Xen-devel] [PATCH v2 3/3] paravirt: rename paravirt_enabled to paravirt_legacy Date: Mon, 8 Feb 2016 16:38:40 +0000 Message-ID: <56B8C490.1060004@citrix.com> References: <20160206085930.GF25240@wotan.suse.de> <20160206220437.GA4435@pd.tnic> <56B8B6BF.6030007@oracle.com> <20160208155507.GF28980@pd.tnic> <56B8BCDB.9040701@citrix.com> <56B8BE58.6070003@oracle.com> <56B8C1BC.9040603@citrix.com> <56B8C2C8.8050406@oracle.com> <20160208163526.GI28980@pd.tnic> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160208163526.GI28980@pd.tnic> Sender: linux-kernel-owner@vger.kernel.org To: Borislav Petkov , Boris Ostrovsky Cc: X86 ML , david.e.box@intel.com, Andrey Ryabinin , Lv Zheng , Jan Beulich , "H. Peter Anvin" , qiuxishi@huawei.com, cocci@systeme.lip6.fr, Xen Devel , Joerg Roedel , "Rafael J. Wysocki" , Robert Moore , Ingo Molnar , Andrey Ryabinin , Mauro Carvalho Chehab , "Luis R. Rodriguez" , Rusty Russell , Thomas Gleixner , mcb30@ipxe.org, Juergen Gross , "linux-kernel@vger.kernel.org" , Andy Lutomirski , "Luis R. Rodriguez" , long.wanglong@huawei.com, Fengguan List-Id: xen-devel@lists.xenproject.org On 08/02/16 16:35, Borislav Petkov wrote: > On Mon, Feb 08, 2016 at 11:31:04AM -0500, Boris Ostrovsky wrote: >> I think we are OK for PV because this code will be executed after pvops are >> set and so we will be calling xen_cpuid(). > Not for the early loader - it is too early for pvops then. So you're > saying something like that won't work? Correct. PV guests are ring-deprivilelged so the cpuid instruction doesn't trap in general. (It does on more modern Intel hardware with cpuid faulting enabled, but that is only IvyBridge and newer). Does the early loader have extable support? If so, this is fairly easy to fix. If not, we have a problem. ~Andrew