From: Razvan Cojocaru <rcojocaru@bitdefender.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: tamas@tklengyel.com, wei.liu2@citrix.com,
ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com,
andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com,
xen-devel@lists.xen.org, stefano.stabellini@citrix.com,
keir@xen.org
Subject: Re: [PATCH] vm_event: Remove xc_mem_access_enable_emulate() and friends
Date: Fri, 12 Feb 2016 11:15:38 +0200 [thread overview]
Message-ID: <56BDA2BA.2000108@bitdefender.com> (raw)
In-Reply-To: <56BDAF9902000078000D14B4@prv-mh.provo.novell.com>
On 02/12/2016 11:10 AM, Jan Beulich wrote:
>>>> On 12.02.16 at 10:04, <rcojocaru@bitdefender.com> wrote:
>> --- a/xen/include/public/memory.h
>> +++ b/xen/include/public/memory.h
>> @@ -390,8 +390,6 @@ DEFINE_XEN_GUEST_HANDLE(xen_mem_paging_op_t);
>> #define XENMEM_access_op 21
>> #define XENMEM_access_op_set_access 0
>> #define XENMEM_access_op_get_access 1
>> -#define XENMEM_access_op_enable_emulate 2
>> -#define XENMEM_access_op_disable_emulate 3
>
> Considering that the interface isn't versioned, I think you should
> just comment those out instead of entirely removing them, to
> make obvious for the next one to add an operation here that
> these two values may not be re-used.
Right, I'll do that in V2.
Thanks,
Razvan
next prev parent reply other threads:[~2016-02-12 9:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 9:04 [PATCH] vm_event: Remove xc_mem_access_enable_emulate() and friends Razvan Cojocaru
2016-02-12 9:10 ` Jan Beulich
2016-02-12 9:15 ` Razvan Cojocaru [this message]
2016-02-12 12:06 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BDA2BA.2000108@bitdefender.com \
--to=rcojocaru@bitdefender.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tamas@tklengyel.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).