From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] tools/libxc: Fix use of zlib-options when building the domain builder
Date: Mon, 15 Feb 2016 16:21:39 +0100 [thread overview]
Message-ID: <56C1ED03.50807@citrix.com> (raw)
In-Reply-To: <1455304891-31068-1-git-send-email-andrew.cooper3@citrix.com>
El 12/2/16 a les 20:21, Andrew Cooper ha escrit:
> c/s de0f8c7c changed the use of zlib-options, and moved it from being locally
> generated to coming from ./configure.
>
> However, it neglected to modify the users of zlib-options. The curious use of
> $(call ...) was to select either the -D or -l options as appropriate, but c/s
> de0f8c7c broke this by loosing the `grep`.
>
> Instead, use $(filter ...) to pick out either the -D or -l options. This
> fixes the build with Clang, which complains at passing '-llzma' when trying
> to compile xc_dom_bzimageloader.c to xc_dom_bzimageloader.o.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Wow, good catch, thanks.
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Roger.
next prev parent reply other threads:[~2016-02-15 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 19:21 [PATCH] tools/libxc: Fix use of zlib-options when building the domain builder Andrew Cooper
2016-02-15 11:57 ` Wei Liu
2016-02-15 15:21 ` Roger Pau Monné [this message]
2016-02-15 17:06 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C1ED03.50807@citrix.com \
--to=roger.pau@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).