From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= <roger.pau@citrix.com>
Subject: Re: [PATCH] tools/libxc: Fix use of zlib-options when
 building the domain builder
Date: Mon, 15 Feb 2016 16:21:39 +0100
Message-ID: <56C1ED03.50807@citrix.com>
References: <1455304891-31068-1-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1455304891-31068-1-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

El 12/2/16 a les 20:21, Andrew Cooper ha escrit:
> c/s de0f8c7c changed the use of zlib-options, and moved it from being loc=
ally
> generated to coming from ./configure.
> =

> However, it neglected to modify the users of zlib-options.  The curious u=
se of
> $(call ...) was to select either the -D or -l options as appropriate, but=
 c/s
> de0f8c7c broke this by loosing the `grep`.
> =

> Instead, use $(filter ...) to pick out either the -D or -l options.  This
> fixes the build with Clang, which complains at passing '-llzma' when tryi=
ng
> to compile xc_dom_bzimageloader.c to xc_dom_bzimageloader.o.
> =

> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Wow, good catch, thanks.

Acked-by: Roger Pau Monn=E9 <roger.pau@citrix.com>

Roger.