From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2 05/30] xen/public: Export cpu featureset
 information in the public API
Date: Wed, 17 Feb 2016 13:08:56 +0000
Message-ID: <56C470E8.3030907@citrix.com>
References: <1454679743-18133-1-git-send-email-andrew.cooper3@citrix.com>
	<1454679743-18133-6-git-send-email-andrew.cooper3@citrix.com>
	<56BE15EA02000078000D1806@prv-mh.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <56BE15EA02000078000D1806@prv-mh.provo.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Tim Deegan <tim@xen.org>, Ian Campbell <Ian.Campbell@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 12/02/16 16:27, Jan Beulich wrote:
>>>> On 05.02.16 at 14:41, <andrew.cooper3@citrix.com> wrote:
>> +/* Intel-defined CPU features, CPUID level 0x00000001.edx, word 0 */
>> +#define X86_FEATURE_FPU           ( 0*32+ 0) /*   Onboard FPU */
> Regardless of you limiting the interface to tools only, I'm not
> convinced exposing constants starting with X86_* here is
> appropriate.

The toolstack already uses these exact names.  Patch 25 depends on me
not changing any of these.

>
>> +#define X86_FEATURE_XMM           ( 0*32+25) /*   Streaming SIMD Extensions */
>> +#define X86_FEATURE_XMM2          ( 0*32+26) /*   Streaming SIMD Extensions-2 */
>> [...]
>> +/* Intel-defined CPU features, CPUID level 0x00000001.ecx, word 1 */
>> +#define X86_FEATURE_XMM3          ( 1*32+ 0) /*   Streaming SIMD Extensions-3 */
> Apart from that exposing them should be done using canonical instead
> of Linux-invented names, i.e. s/XMM/SSE/ for the above lines. I've
> had a need to create a patch to do this just earlier today.

I can do this as a preparatory patch.  Any other names you want to me to
change?

~Andrew