xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] x86/PVHv2: add XEN_ prefix to HVM_START_MAGIC_VALUE
@ 2016-02-19 10:28 Roger Pau Monne
  2016-02-19 10:56 ` Andrew Cooper
  2016-02-19 15:45 ` Roger Pau Monné
  0 siblings, 2 replies; 3+ messages in thread
From: Roger Pau Monne @ 2016-02-19 10:28 UTC (permalink / raw)
  To: xen-devel; +Cc: Andrew Cooper, Jan Beulich, Roger Pau Monne

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reported by: Jan Beulich <jbeulich@suse.com>
---
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
---
 tools/libxc/xc_dom_x86.c | 2 +-
 xen/include/public/xen.h | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c
index ac4dae5..e13a4aa 100644
--- a/tools/libxc/xc_dom_x86.c
+++ b/tools/libxc/xc_dom_x86.c
@@ -1753,7 +1753,7 @@ static int bootlate_hvm(struct xc_dom_image *dom)
             start_info->nr_modules = 1;
         }
 
-        start_info->magic = HVM_START_MAGIC_VALUE;
+        start_info->magic = XEN_HVM_START_MAGIC_VALUE;
 
         munmap(start_page, start_info_size);
     }
diff --git a/xen/include/public/xen.h b/xen/include/public/xen.h
index ad00bf9..64ba7ab 100644
--- a/xen/include/public/xen.h
+++ b/xen/include/public/xen.h
@@ -804,7 +804,7 @@ typedef struct start_info start_info_t;
  * of the address fields should be treated as not present.
  *
  *  0 +----------------+
- *    | magic          | Contains the magic value HVM_START_MAGIC_VALUE
+ *    | magic          | Contains the magic value XEN_HVM_START_MAGIC_VALUE
  *    |                | ("xEn3" with the 0x80 bit of the "E" set).
  *  4 +----------------+
  *    | version        | Version of this structure. Current version is 0. New
@@ -839,7 +839,7 @@ typedef struct start_info start_info_t;
  * The address and size of the modules is a 64bit unsigned integer. However
  * Xen will always try to place all modules below the 4GiB boundary.
  */
-#define HVM_START_MAGIC_VALUE 0x336ec578
+#define XEN_HVM_START_MAGIC_VALUE 0x336ec578
 
 /* New console union for dom0 introduced in 0x00030203. */
 #if __XEN_INTERFACE_VERSION__ < 0x00030203
-- 
2.5.4 (Apple Git-61)


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] x86/PVHv2: add XEN_ prefix to HVM_START_MAGIC_VALUE
  2016-02-19 10:28 [PATCH] x86/PVHv2: add XEN_ prefix to HVM_START_MAGIC_VALUE Roger Pau Monne
@ 2016-02-19 10:56 ` Andrew Cooper
  2016-02-19 15:45 ` Roger Pau Monné
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Cooper @ 2016-02-19 10:56 UTC (permalink / raw)
  To: Roger Pau Monne, xen-devel; +Cc: Jan Beulich

On 19/02/16 10:28, Roger Pau Monne wrote:
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Reported by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] x86/PVHv2: add XEN_ prefix to HVM_START_MAGIC_VALUE
  2016-02-19 10:28 [PATCH] x86/PVHv2: add XEN_ prefix to HVM_START_MAGIC_VALUE Roger Pau Monne
  2016-02-19 10:56 ` Andrew Cooper
@ 2016-02-19 15:45 ` Roger Pau Monné
  1 sibling, 0 replies; 3+ messages in thread
From: Roger Pau Monné @ 2016-02-19 15:45 UTC (permalink / raw)
  To: xen-devel
  Cc: Wei Liu, Ian Campbell, Andrew Cooper, Ian Jackson, David Vrabel,
	Jan Beulich, Boris Ostrovsky

Ccing the tools maintainers, according to the output from get_maintaner.pl

Also adding the Linux folks.

El 19/2/16 a les 11:28, Roger Pau Monne ha escrit:
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Reported by: Jan Beulich <jbeulich@suse.com>
> ---
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
>  tools/libxc/xc_dom_x86.c | 2 +-
>  xen/include/public/xen.h | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c
> index ac4dae5..e13a4aa 100644
> --- a/tools/libxc/xc_dom_x86.c
> +++ b/tools/libxc/xc_dom_x86.c
> @@ -1753,7 +1753,7 @@ static int bootlate_hvm(struct xc_dom_image *dom)
>              start_info->nr_modules = 1;
>          }
>  
> -        start_info->magic = HVM_START_MAGIC_VALUE;
> +        start_info->magic = XEN_HVM_START_MAGIC_VALUE;
>  
>          munmap(start_page, start_info_size);
>      }
> diff --git a/xen/include/public/xen.h b/xen/include/public/xen.h
> index ad00bf9..64ba7ab 100644
> --- a/xen/include/public/xen.h
> +++ b/xen/include/public/xen.h
> @@ -804,7 +804,7 @@ typedef struct start_info start_info_t;
>   * of the address fields should be treated as not present.
>   *
>   *  0 +----------------+
> - *    | magic          | Contains the magic value HVM_START_MAGIC_VALUE
> + *    | magic          | Contains the magic value XEN_HVM_START_MAGIC_VALUE
>   *    |                | ("xEn3" with the 0x80 bit of the "E" set).
>   *  4 +----------------+
>   *    | version        | Version of this structure. Current version is 0. New
> @@ -839,7 +839,7 @@ typedef struct start_info start_info_t;
>   * The address and size of the modules is a 64bit unsigned integer. However
>   * Xen will always try to place all modules below the 4GiB boundary.
>   */
> -#define HVM_START_MAGIC_VALUE 0x336ec578
> +#define XEN_HVM_START_MAGIC_VALUE 0x336ec578
>  
>  /* New console union for dom0 introduced in 0x00030203. */
>  #if __XEN_INTERFACE_VERSION__ < 0x00030203
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-02-19 15:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-19 10:28 [PATCH] x86/PVHv2: add XEN_ prefix to HVM_START_MAGIC_VALUE Roger Pau Monne
2016-02-19 10:56 ` Andrew Cooper
2016-02-19 15:45 ` Roger Pau Monné

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).