From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>,
hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
luto@amacapital.net, rusty@rustcorp.com.au,
david.vrabel@citrix.com, konrad.wilk@oracle.com, mcb30@ipxe.org,
jgross@suse.com, andriy.shevchenko@linux.intel.com,
xen-devel@lists.xensource.com
Subject: Re: [RFC v2 1/6] x86/boot: add BIT() to boot/bitops.h
Date: Fri, 19 Feb 2016 10:14:42 -0500 [thread overview]
Message-ID: <56C73162.1040207@oracle.com> (raw)
In-Reply-To: <1455891343-10016-2-git-send-email-mcgrof@kernel.org>
On 02/19/2016 09:15 AM, Luis R. Rodriguez wrote:
> diff --git a/arch/x86/boot/bitops.h b/arch/x86/boot/bitops.h
> index 878e4b9940d9..232cff0ff4e3 100644
> --- a/arch/x86/boot/bitops.h
> +++ b/arch/x86/boot/bitops.h
> @@ -40,4 +40,6 @@ static inline void set_bit(int nr, void *addr)
> asm("btsl %1,%0" : "+m" (*(u32 *)addr) : "Ir" (nr));
> }
>
> +#define BIT(x) (1 << x)
Parenthesize x.
next prev parent reply other threads:[~2016-02-19 15:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 14:15 [RFC v2 0/6] x86/init: use linker table Luis R. Rodriguez
2016-02-19 14:15 ` [RFC v2 1/6] x86/boot: add BIT() to boot/bitops.h Luis R. Rodriguez
2016-02-19 15:14 ` Boris Ostrovsky [this message]
2016-02-19 21:03 ` Luis R. Rodriguez
2016-02-19 14:15 ` [RFC v2 2/6] x86/init: use linker tables to simplify x86 init and annotate dependencies Luis R. Rodriguez
2016-02-19 16:40 ` Andy Lutomirski
2016-02-20 0:42 ` Luis R. Rodriguez
2016-02-20 7:30 ` Andy Lutomirski
2016-02-27 0:19 ` Luis R. Rodriguez
2016-02-19 14:15 ` [RFC v2 3/6] x86/init: move ebda reservations into linker table Luis R. Rodriguez
2016-02-19 14:15 ` [RFC v2 4/6] x86/init: use linker table for i386 early setup Luis R. Rodriguez
2016-02-19 14:15 ` [RFC v2 5/6] x86/init: user linker table for ce4100 " Luis R. Rodriguez
2016-02-19 14:15 ` [RFC v2 6/6] x86/init: use linker table for mid " Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C73162.1040207@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=david.vrabel@citrix.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mcb30@ipxe.org \
--cc=mcgrof@kernel.org \
--cc=mingo@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).